🤖 fix: link workspace task cards#3613
Merged
Merged
Conversation
Show workspace-task cards as workspace instead of unknown and route their badges/task IDs to the created workspace when metadata is available.\n\n---\n\n_Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `1265353MUX_COSTS_USD`_\n\n<!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=13.04 -->
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workspace task tool cards now render workspace-turn tasks as
workspaceinstead ofunknown, and the workspace badge/task ID opens the created workspace when its metadata is available.Background
Workspace-turn task IDs are handles (
wst_...), not actual workspace IDs. The task tool already returns the createdworkspaceId, but the UI only looked up metadata by task ID, so workspace tasks appeared as unknown and were not directly navigable.Implementation
args.kindso workspace tasks render asworkspace.workspaceIdvalues in task, task_await, and task_list rows.workspaceIdfirst, then direct metadata lookup, then persistedmux.taskHandleIdtags.Validation
bun test src/browser/features/Tools/TaskToolCall.test.tsxmake typecheckMUX_ESLINT_CONCURRENCY=1 make lintMUX_ESLINT_CONCURRENCY=1 make static-checkRisks
Low-to-medium UI risk. The change is limited to task tool rendering/navigation, but that component handles multiple task sources (subagents, workspace turns, task_await, task_list), so regressions would most likely appear as incorrect task badges or lost workspace navigation affordances.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$13.04