🤖 fix: support JSON attachments#3601
Open
LeonidasZhak wants to merge 1 commit into
Open
Conversation
Allow application/json files through the attachment media-type allowlist and file picker, with focused coverage for MIME and extension-based JSON attachment handling. Generated with mux • Model: GPT-5 • Thinking: unknown • Cost: mux-attribution: model=GPT-5 thinking=unknown costs=unknown
Author
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow JSON files to be attached in the chat composer by accepting
application/jsonand.jsonthrough the existing attachment media-type flow.Background
Fixes #3546. JSON files currently fail the frontend attachment validation as unsupported even though the send path already carries non-image file parts through the generic file attachment path.
Implementation
application/jsonand.jsonto the supported attachment media-type helpers.Validation
bun test src/browser/utils/attachmentsHandling.test.ts src/common/utils/attachments/supportedAttachmentMediaTypes.test.ts src/node/utils/messages/convertDataUriFilePartsForSdk.test.ts- 22 tests passed./node_modules/.bin/eslint src/common/utils/attachments/supportedAttachmentMediaTypes.ts src/common/utils/attachments/supportedAttachmentMediaTypes.test.ts src/browser/utils/attachmentsHandling.test.ts src/browser/features/ChatInput/AttachFileButton.tsx./scripts/generate-version.sh./node_modules/.bin/tsgo --noEmit --project tsconfig.jsongit diff --checkmake static-check- passed with a local Bun shim on PATHRisks
Low. This expands the attachment allowlist only for JSON files and reuses the existing generic non-image file display/send path.
Generated with
mux• Model:GPT-5• Thinking:unknown• Cost:$unknown