🤖 refactor: auto-cleanup

[mux-bot]

Summary

Long-lived auto-cleanup PR that accumulates low-risk,
behavior-preserving refactors picked from recent main commits.

Changes

Use shared isAbortError utility in AuthTokenModal

Replace two inline error instanceof DOMException && error.name === "AbortError"
checks in AuthTokenModal.tsx with the existing shared isAbortError() utility
from @/browser/utils/isAbortError, deduplicating the abort detection logic.

Extract extractChunkDeltaText helper to deduplicate advisor chunk parsing

Pull the repeated switch over chunk.type (extracting chunk.textDelta or
chunk.argsTextDelta) into a single extractChunkDeltaText() helper in
advisorService.ts, then call it from both executeAdvisorStream and
executeAdvisorStreamWithRetry.

Remove unnecessary exports from skillFileUtils

Un-export parseSkillFile, serializeSkillFile, and SKILL_FILENAME from
src/node/services/agentSkills/skillFileUtils.ts — all three are only used
within the same file, so the export keyword was unnecessary.

Remove dead getCancelledCompactionKey storage helper

Remove the getCancelledCompactionKey function and its entry in the
EPHEMERAL_WORKSPACE_KEY_FUNCTIONS array from storage.ts — the only consumer
(useResumeManager.ts) was deleted, leaving this as dead code.

Remove dead quickReviewNotes module

Remove src/browser/utils/review/quickReviewNotes.ts and its test file
(482 lines). The buildQuickLineReviewNote and buildQuickHunkReviewNote
functions were never imported by any production code since their introduction
in PR #2448.

Un-export isBashOutputTool in messageUtils

Remove the export keyword from isBashOutputTool in
src/browser/utils/messages/messageUtils.ts — the type guard is only
used within the same file by computeBashOutputGroupInfos, so the
export was unnecessary.

Deduplicate hasErrorCode in submoduleSync

Replace inline NodeJS.ErrnoException-like error-code checks in
submoduleSync.ts with calls to the existing hasErrorCode helper,
keeping a single canonical place where error-code narrowing lives.

Simplify hasCompletedDescendants to reuse listCompletedDescendantAgentTaskIds

Rewrite hasCompletedDescendants to delegate to the existing
listCompletedDescendantAgentTaskIds helper instead of re-implementing the
traversal, collapsing the two code paths into one.

Reuse anthropicSupportsNativeXhigh in Anthropic fetch wrapper

Replace the duplicated Opus 4.7+ regex inside
wrapFetchWithAnthropicCacheControl (src/node/services/providerModelFactory.ts)
with a call to the existing anthropicSupportsNativeXhigh helper from
src/common/types/thinking.ts. The helper already performs the same regex
check plus provider-prefix normalization (e.g.,
anthropic/claude-opus-4-7 via the ai-model-id gateway header), keeping the
wire-level detection and the policy-level detection in one place.

Extract getFetchInputUrl helper to deduplicate URL extraction

The OpenAI/Codex and Copilot fetch wrappers in providerModelFactory.ts each
contained an identical 15-line IIFE that extracted a URL string from the
fetch input argument (handling string, URL, and Request-like shapes).
Extract the logic into a single getFetchInputUrl helper so both wrappers
share one implementation. Behavior-preserving: the helper returns the same
empty-string fallback on unrecognized inputs, so callers continue to fall
through to normal fetch behavior without throwing.

Extract clonePersistedToolModelUsage helper in streamManager

The deep-clone pattern for PersistedToolModelUsage (spread event, fresh
usage object, conditional providerMetadata) was duplicated between
recordToolModelUsage and the stream-end tool-usage snapshot in
streamManager.ts. Extract a single file-local helper so both sites share
the same implementation. Behavior-preserving: both callsites continue to
produce structurally identical clones.

Reuse getClosestTranscriptAncestor in getTranscriptContextMenuLink

The new getTranscriptContextMenuLink helper (added in #3188) inlined
the same "resolve event target → element.closest(selector) → require
both to stay within the transcript root" pattern that
getClosestTranscriptAncestor — defined a few lines above in the same
file — already implements. Delegate to the shared helper so the
null/contains guards live in one place. Behavior-preserving: the
helper returns null for a null/outside-root target, then
element.closest("a[href]"), then null again if the anchor is outside
the transcript root — identical to the previous inline checks. All 22
transcriptContextMenu tests continue to pass.

Remove duplicate gpt-5.5-pro thinking-policy test

When #3192 renamed gpt-5.4-pro → gpt-5.5-pro across
src/common/utils/thinking/policy.test.ts, it accidentally introduced a
third returns medium/high/xhigh for gpt-5.5-pro test that is
byte-identical to the renamed first occurrence (the two remaining tests
are the bare-prefix and with version suffix variants; the deleted block
had no version suffix and no gateway prefix). Drop the duplicate so the
suite has one canonical no-suffix test, one mux-gateway test, and one
version-suffix test. Behavior-preserving — getThinkingPolicyForModel
coverage for gpt-5.5-pro is unchanged; 63 / 63 tests in policy.test.ts
continue to pass.

The earlier "sync thinking-policy doc comments with gpt-5.5 regex"
cleanup was dropped during rebase: #3192 superseded it by retiring
gpt-5.4 from those comments entirely, so the comment-only diff
became redundant.

Auto-cleanup checkpoint: 797d5a2

---

Generated with mux • Model: anthropic:claude-opus-4-7 • Thinking: xhigh

[mux-bot]

@codex review

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[mux-bot]

⚠️ Auto-fixup could not resolve CI failure: The integration test failures in tests/ui/compaction/compaction.test.ts are flaky tests, not caused by the cleanup commits.

Evidence:

• The test file has zero diff vs origin/main — it was not modified by this PR
• The code changes (removing dead getCancelledCompactionKey, extracting extractChunkDeltaText helper, removing unused exports, using shared isAbortError) do not affect compaction logic
• Both CI-failing tests (force compaction triggers during streaming, /compact with Ctrl+Enter does NOT auto-background foreground bash) pass locally when run individually or together (under 7s each)
• When running the full compaction test suite, different tests fail on each run — classic sign of test pollution / resource contention in CI
• make static-check and make typecheck pass cleanly
• main CI has been consistently green

Recommendation: Re-run the failed CI job. The compaction test suite has latent test pollution that surfaces under CI load.

[mux-bot]

⚠️ Auto-fixup: CI failure is a flaky test — no fix pushed.

Failed job: Test / Integration
Failed tests: tests/ui/compaction/compaction.test.ts — 2 tests fail intermittently:

1. Timeout (120s) waiting for "Compaction boundary" in transcript
2. "Project not found in sidebar" (cascading failure after test 1 times out)

Root cause analysis:

• The PR changes (getCancelledCompactionKey removal, extractChunkDeltaText refactor, etc.) do not modify any test files, compaction logic, or UI rendering code.
• Each failing test passes in isolation locally (4.5s and 6.7s respectively).
• The failures only occur when running the full suite, with different tests failing each run — classic timing/resource flake.
• Previous CI run on the same branch (run 24429941886) showed the same pattern with different specific test failures.
• git diff origin/main HEAD -- tests/ shows zero changes to test files.

Recommendation: Re-run CI. These compaction UI tests have known flakiness under CI resource constraints.

[mux-bot]

⚠️ Auto-fixup could not resolve CI failure: the only failing job was Test / Integration on tests/ipc/compaction1MRetry.integration.test.ts with errorType=server_error, error=Internal server error — a transient Anthropic HTTP 500 from the upstream API.

This appears to be a flaky integration test, not caused by the auto-cleanup commits:

• All 10 commits on this branch are pure refactors (extract helpers, de-export unused symbols, reuse shared regex, delete a dead getCancelledCompactionKey storage helper that had no callers on main).
• No diff touches the compaction send path, 1M-context retry logic, Anthropic error mapping, or request construction.
• Every other integration tier in the same run passed (OpenAI, Anthropic reasoning, image handling, sendMessage errors, etc.), so credentials and environment are healthy.
• The test already retries HTTP 529 "Overloaded" and treats it as inconclusive on CI, but does not cover HTTP 500 "Internal server error" the same way — hence a transient upstream 500 surfaces as a hard failure.

No code change pushed. Re-running the workflow should clear it; if this recurs, consider extending the test's transient-error retry list to include HTTP 500 alongside 529. Manual intervention needed only if it reproduces on rerun.