Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b5afd6282
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ammar-agent
force-pushed
the
fork-1z8m
branch
3 times, most recently
from
f46c527 to
90aac9c
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c8e91ffbe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ammar-agent
force-pushed
the
fork-1z8m
branch
2 times, most recently
from
917c32f to
61b3388
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a753f4b509
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f43c39eb5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b2fa90644
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2960a16bb5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed the latest two comments:
Also completed integration-test stabilization work and verified locally with:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30a41c8cd7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ation
- Schema: add autoName flag to WorkspaceMetadata and WorkspaceConfig
- Backend: auto-generate fork branch names ({parent}-fork-N pattern)
when /fork is used without an explicit name
- Backend: clear autoName flag on any title update (manual rename or
auto-generated) to exit the provisional naming state
- Frontend: simplify /fork command - bare /fork works, everything after
is treated as a start message
- Frontend: auto-name on first message via nameGeneration IPC
(fire-and-forget, reuses existing LLM title generation pipeline)
- Frontend: italic styling in sidebar for auto-name workspaces
- Remove fork-help toast (no longer needed since bare /fork works)
- Tests: update fork command tests, add generateForkBranchName unit tests
Move the auto-naming trigger from ChatInput (frontend) to WorkspaceService.sendMessage (backend), fixing three issues: 1. Eliminates duplicate candidate-building logic that was missing gateway model transforms (bug) 2. Includes prior assistant message from forked history for richer title generation context 3. Colocates the trigger with existing fire-and-forget side effects (updateRecencyTimestamp pattern) Changes: - Add autoGenerateTitle() private method to WorkspaceService - Trigger from sendMessage after recency timestamp update - Add assistantContext param to generateWorkspaceIdentity prompt - Remove auto-naming block, refs, and imports from ChatInput - Un-export NAME_GEN_PREFERRED_MODELS (now module-private)
- Add RENAME_WORKSPACE and REGENERATE_WORKSPACE_NAME to keybinds registry - Add workspace.regenerateTitle backend endpoint (reads first user message + assistant reply from history, calls generateWorkspaceIdentity, persists via updateTitle) - Add SidebarRenameKeybinds component inside RenameProvider for F2/Shift+F2 (F2 enters inline edit mode, Shift+F2 calls regenerateTitle API) - Update WorkspaceListItem context menu: F2 hint on 'Edit chat title', new 'Generate new title' item with Shift+F2 hint and Sparkles icon - Add command palette entries with shortcut hints - Add keybind labels + navigation group entries in KeybindsSection
All rename/name terminology updated to reflect that this feature is about workspace *titles*, not workspace names/branches: Keybinds: - RENAME_WORKSPACE → EDIT_WORKSPACE_TITLE - REGENERATE_WORKSPACE_NAME → GENERATE_WORKSPACE_TITLE Commands: - ws:rename → ws:edit-title (+ ws:rename-any → ws:edit-title-any) - ws:regenerate-name → ws:generate-title Context: - WorkspaceRenameContext.tsx → WorkspaceTitleEditContext.tsx (git mv) - RenameProvider → TitleEditProvider, useRename → useTitleEdit - requestRename/confirmRename/cancelRename → requestEdit/confirmEdit/cancelEdit WorkspaceContext: - renameWorkspace → updateWorkspaceTitle - onRenameWorkspace → onUpdateTitle (command palette sources + App.tsx) Schema: - autoName → autoTitle (project + workspace schemas, workspaceService) UI strings updated: 'Rename Workspace' → 'Edit Workspace Title', field labels from 'name' to 'title', initial values from .name to .title
When Shift+F2 or 'Generate new title' triggers regenerateTitle, the sidebar title now shimmers (using the existing Shimmer component) and renders in italic — matching the autoTitle placeholder style. TitleEditContext gains generatingTitleWorkspaceId state and a wrapGenerateTitle(workspaceId, asyncFn) helper that manages the loading lifecycle. Both call sites (keybind handler in ProjectSidebar, context menu in WorkspaceListItem) use the wrapper so the loading state is consistent regardless of entry point.
Replace the lazy AI title generation on fork with a simple numbered suffix: forking "Fix sidebar" produces "Fix sidebar (1)", then "Fix sidebar (2)", etc. The suffix logic strips any existing "(N)" from the parent title before incrementing, so forking "Fix sidebar (2)" yields "Fix sidebar (3)" — not "Fix sidebar (2) (1)". Removed: - autoTitle field from project + workspace schemas - autoGenerateTitle() method in WorkspaceService - sendMessage trigger that called autoGenerateTitle on first message - autoTitle clearing in updateTitle - Italic styling for autoTitle in WorkspaceListItem Users can still manually generate a new AI title any time via Shift+F2 or the context menu "Generate new title" action. Added: - generateForkTitle() helper (+ 5 unit tests)
Move gateway resolution from scattered call sites into ProviderModelFactory.createModel(), so every model instantiation automatically routes through the gateway when configured. Changes: - createModel now calls resolveGatewayModelString (idempotent) - Remove manual gateway resolution from system1ToolWrapper - Remove resolveGatewayModelString from AIService public API - Simplify frontend buildNameGenCandidates (no gateway transform needed) - Extract NAME_GEN_PREFERRED_MODELS to shared constant - Update schema/router comments to reflect new behavior
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dc552bb90
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8a7fd2601
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed the fork title suffix parsing feedback:
Please re-review. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e4d4cf2b6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed latest comments:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3bf6996c7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed loading-state concurrency for title regeneration:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de7b75145c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed latest review items:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb9acc5a7a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed latest comments:
All local checks and targeted tests are green. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e457ebc1e6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed assistant-context ordering in
|
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
2 participants
Summary
This PR delivers seamless fork semantics, robust workspace title regeneration, and backend-authoritative gateway model routing. Forking now auto-generates deterministic numbered names/titles, title regeneration is deduped and correctly tracked per workspace, and gateway users no longer rely on frontend model-string rewriting.
Background
Two sources of friction were addressed:
Codex review also surfaced correctness issues around suffix parsing, stale-branch collisions, command routing consistency, and assistant-context selection for title regeneration.
Implementation
Fork semantics and collision handling
copyIfExistshelper.Title regeneration correctness
workspace.regenerateTitlepath hardening to use the first assistant reply after the first user message as context.Command/UI routing consistency
WORKSPACE_GENERATE_TITLE_REQUESTED) and a shared sidebar handler.Gateway routing centralization
ProviderModelFactory.createModel()resolves gateway routing internally (idempotent).Validation
make static-checkpassed.src/node/services/workspaceService.test.tssrc/node/services/providerModelFactory.test.tssrc/browser/contexts/WorkspaceTitleEditContext.test.tsxsrc/browser/utils/commands/sources.test.tsRisks
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:low• Cost:$59.78