feat(audit): add per-session sequence counter#195
Closed
SasSwart wants to merge 1 commit intosas/session-id-at-startupfrom
Closed
feat(audit): add per-session sequence counter#195SasSwart wants to merge 1 commit intosas/session-id-at-startupfrom
SasSwart wants to merge 1 commit intosas/session-id-at-startupfrom
Conversation
Introduce SequenceCounter, a shared atomic uint64 counter intended to be initialized once per boundary session and shared between the socket auditor and the proxy. The Next() method returns a zero-based, monotonically increasing value so the audit event and any injected header for the same request agree on the sequence number. No wiring yet; this commit only adds the type and its tests.
SasSwart
force-pushed
the
sasswart/feat-audit-sequence-counter
branch
from
3a1ab26 to
2bcedd2
Compare
This was referenced Apr 30, 2026
Contributor
Author
|
Closing in favour of #196, which now includes this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Map
Introduces
SequenceCounter, a sharedatomic.Uint64counter intended to be initialized once per boundary session and shared between the socket auditor and the proxy.Next()returns a zero-based, monotonically increasing value so the audit event and any injected header for the same request agree on the sequence number.No wiring yet; this PR only adds the type and its tests.
Changes
audit/sequence.go:SequenceCountertype withNext()helper.audit/sequence_test.go: Tests covering zero-start, sequential increment, concurrent safety (8 goroutines x 1000 calls, no duplicates/gaps), and independent instance isolation.