Skip to content

chore: lint fixes part 5#257

Merged
pawbana merged 3 commits intomainfrom
pb/coder-lint-fix5
Apr 13, 2026
Merged

chore: lint fixes part 5#257
pawbana merged 3 commits intomainfrom
pb/coder-lint-fix5

Conversation

@pawbana
Copy link
Copy Markdown
Contributor

@pawbana pawbana commented Apr 10, 2026

  • errname (3): UnknownRoute → ErrUnknownRoute; errorResponse → responseError (chatcompletions); ErrorResponse → responseError (messages)
  • slog field names (4): "%+v" nested slog.F → direct value; requestPath/upstreamPath → request_path/upstream_path (snake_case)
  • slog message length (5): "failed to flush" → "failed to flush event stream"; "stream failed" → "stream processing failed" (2x); "unknown error" → "unknown stream error" (2x)
  • slog message case (1): "MCP client initialized" → "mcp client initialized"
  • gosec G115 (4): added nolint:gosec for test constant uint32→int32 conversions
  • errcheck (1): explicitly discarded RecordInterceptionEnded return value
  • ineffassign (3): propagated streamCtx.Err() to interceptionErr instead of dead lastErr; added nolint:ineffassign for intentional prompt/promptFound resets

@pawbana pawbana force-pushed the pb/coder-lint-fix4 branch from edd1f90 to e1765bc Compare April 13, 2026 11:30
@pawbana pawbana force-pushed the pb/coder-lint-fix5 branch 2 times, most recently from 240e79c to 02b6daf Compare April 13, 2026 11:41
Copy link
Copy Markdown
Contributor Author

pawbana commented Apr 13, 2026

Merge activity

  • Apr 13, 3:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 13, 3:13 PM UTC: Graphite couldn't merge this pull request because a downstack PR chore: lint fixes part 1 (automatic fixes) #253 failed to merge.
  • Apr 13, 3:24 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 13, 3:32 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 13, 3:33 PM UTC: @pawbana merged this pull request with Graphite.

@pawbana pawbana force-pushed the pb/coder-lint-fix5 branch from 3720ab4 to f206eb4 Compare April 13, 2026 15:22
@pawbana pawbana force-pushed the pb/coder-lint-fix4 branch from e7bd5a3 to 3a516ee Compare April 13, 2026 15:22
@pawbana pawbana changed the base branch from pb/coder-lint-fix4 to graphite-base/257 April 13, 2026 15:30
@pawbana pawbana changed the base branch from graphite-base/257 to main April 13, 2026 15:31
@pawbana pawbana force-pushed the pb/coder-lint-fix5 branch from f206eb4 to e8cc9b2 Compare April 13, 2026 15:32
@pawbana pawbana merged commit bbafb9c into main Apr 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants