refactor: improve UX on key:generate#10181
Open
paulbalandan wants to merge 1 commit intocodeigniter4:4.8from
Open
refactor: improve UX on key:generate#10181paulbalandan wants to merge 1 commit intocodeigniter4:4.8from
key:generate#10181paulbalandan wants to merge 1 commit intocodeigniter4:4.8from
Conversation
56cdba2 to
cee1170
Compare
michalsn
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings
key:generatein line with the UX pattern established by #10126 (logs:clear) and #10174 (key:rotate):EXIT_SUCCESS(with a yellowSetting new encryption key cancelled.notice) instead of treating a valid user choice as an error.Setting new encryption key aborted: pass --force to overwrite the existing key in non-interactive mode.clean_path().envand.envmissing" branch moved out ofwriteNewEncryptionKeyToFile()intoexecute(), so the inline-fallback ("here's your new key") no longer chains into a redundant "Error in setting new encryption key to .env file." right after.CLI::write→CLI::erroron the write-failure path so the message goes to STDERR.is_writable()guard inwriteNewEncryptionKeyToFile()(parallels the RotateKey hardening; lets the failure path be exercised cleanly in tests).The exit-code change is documented under Behavior Changes in the v4.8.0 changelog.
Checklist: