Skip to content

all pages code implements#33

Open
ct-krisha wants to merge 5 commits intodev-v5.4.0from
code-implement
Open

all pages code implements#33
ct-krisha wants to merge 5 commits intodev-v5.4.0from
code-implement

Conversation

@ct-krisha
Copy link
Copy Markdown

Commit Checklist

  • Remove UNUSED comment code
  • Remove any logging like console.log
  • Remove all warnings and errors while build
  • Check vulnerabilities
  • Make sure build for production is working. Try running command for prod build in local.
  • Fix prettier: npx prettier --write .
  • Fix eslint: npx eslint src\ --fix command
  • Push package.lock only if you used npm, push yarn.lock only if you used yarn. NPM will udpate both lock file so make sure you dont push yarn.lock updated by NPM
  • WCAG

General

  • Follow import structure. module/third-party/files/component/style/types/asset
  • Try to use theme for design like palette, typography, variant, components, etc. (don't use custom color code anyhow)
  • Before adding custom style follow our pre-built components/elements

@ct-krisha ct-krisha changed the title all pages tech updates all pages code implements Apr 30, 2026
Comment thread src/app/demo/dashboard/default/default.component.html Outdated
Comment thread src/app/theme/layout/admin/nav-bar/nav-logo/nav-logo.component.scss Outdated
Comment thread src/app/theme/layout/admin/navigation/navigation.component.scss Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants