Skip to content

fix: Use os.path.join for path construction in folder_searcher #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Use os.path.join for path construction in folder_searcher #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions codecov_cli/helpers/folder_searcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def search_files(
directory
for directory in dirnames
if multipart_exclude_regex.match(
(pathlib.Path(dirpath) / directory).as_posix()
pathlib.Path(os.path.join(str(dirpath), directory)).as_posix()
)
)

Expand All @@ -82,12 +82,12 @@ def search_files(

if search_for_directories:
for directory in dirnames:
dir_path = pathlib.Path(dirpath) / directory
dir_path = pathlib.Path(os.path.join(str(dirpath), directory))
if not this_is_excluded(dir_path) and this_is_included(dir_path):
yield dir_path
else:
for single_filename in filenames:
file_path = pathlib.Path(dirpath) / single_filename
file_path = pathlib.Path(os.path.join(str(dirpath), single_filename))
if not this_is_excluded(file_path) and this_is_included(file_path):
yield file_path

Expand Down
Loading