Skip to content

Fix aiTrace plugin #5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavertMik merged 2 commits into from
Mar 8, 2026
+21 −9
Merged

Fix aiTrace plugin #5478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6f6a73
add fix
DenysKuchma Mar 6, 2026
78cddca
fix
DenysKuchma Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions lib/plugin/aiTrace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export default function (config) {
firstFailedStepSaved = false
})

event.dispatcher.on(event.step.after, async step => {
event.dispatcher.on(event.step.after, step => {
if (!currentTest) return
if (step.status === 'failed') {
testFailed = true
Expand All @@ -140,13 +140,10 @@ export default function (config) {
output.debug(`aiTrace: Skipping failed step "${step.toString()}" - already handled by step.failed event`)
return
}
recorder.add(`save artifacts for step ${step.toString()}`, async () => {
try {
await persistStep(step)
} catch (err) {
output.debug(`aiTrace: Error saving step: ${err.message}`)
}
}, true)
const stepPersistPromise = persistStep(step).catch(err => {
output.debug(`aiTrace: Error saving step: ${err.message}`)
})
recorder.add(`wait aiTrace step persistence: ${step.toString()}`, () => stepPersistPromise, true)
})

event.dispatcher.on(event.step.failed, async step => {
Expand Down Expand Up @@ -284,7 +281,22 @@ export default function (config) {
output.debug(`aiTrace: Browser unavailable, partial artifact capture: ${err.message}`)
}

if (!step.artifacts?.screenshot) {
if (step.artifacts?.screenshot) {
const screenshotPath = path.isAbsolute(step.artifacts.screenshot)
? step.artifacts.screenshot
: path.resolve(dir, step.artifacts.screenshot)
const screenshotFile = path.basename(screenshotPath)
stepData.artifacts.screenshot = screenshotFile
step.artifacts.screenshot = screenshotPath

if (!fs.existsSync(screenshotPath)) {
try {
await helper.saveScreenshot(screenshotPath, config.fullPageScreenshots)
} catch (err) {
output.debug(`aiTrace: Could not save screenshot: ${err.message}`)
}
}
} else {
try {
const screenshotFile = `${stepPrefix}_screenshot.png`
const screenshotPath = path.join(dir, screenshotFile)
Expand Down