Skip to content

feat(#4342) logfile view - chunk navigation#5390

Open
vetri15 wants to merge 7 commits into
codecentric:masterfrom
vetri15:issue-4342-logile-view
Open

feat(#4342) logfile view - chunk navigation#5390
vetri15 wants to merge 7 commits into
codecentric:masterfrom
vetri15:issue-4342-logile-view

Conversation

@vetri15
Copy link
Copy Markdown

@vetri15 vetri15 commented May 24, 2026

Implemented logfile chunk navigation and recovery improvements.

  • Added previous/next chunk navigation
  • Show skipped and remaining byte counts
  • Render only complete log lines across chunk boundaries
  • Automatically reset and resume follow mode after logfile compression
  • Improved tail-follow scroll behavior and manual chunk navigation

vetri15 added 5 commits May 3, 2026 01:15
Add byte-range logfile chunk navigation for skipped content, with a compact follow/page up/page down toolbar that switches between live tailing and manual browsing. Also parse logfile window metadata, show skipped bytes for manual chunks, and add localized navigation labels.
Added previous/next chunk navigation
Show skipped and remaining byte counts
Render only complete log lines across chunk boundaries
Automatically reset and resume follow mode after logfile compression
Improved tail-follow scroll behavior and manual chunk navigation
@vetri15 vetri15 marked this pull request as ready for review May 24, 2026 09:58
@vetri15 vetri15 requested a review from a team as a code owner May 24, 2026 09:58
@vetri15
Copy link
Copy Markdown
Author

vetri15 commented May 24, 2026

Hi @cdprete,

I created a new PR for issue #4342, as I realized my previous approach would not be sufficient to implement this feature cleanly.

I think the previous PR(#5326) can be closed. Could you please review the new PR and let me know if any further changes are needed?

It took longer than I initially expected because of the edge cases involved.

@cdprete
Copy link
Copy Markdown
Contributor

cdprete commented May 24, 2026

Hi @vetri15.

You can close the old PR yourself if you think the new one supersedes it.

Could you please review the new PR and let me know if any further changes are needed?

I try to do it asap.

It took longer than I initially expected because of the edge cases involved.

No worries.

@cdprete
Copy link
Copy Markdown
Contributor

cdprete commented May 24, 2026

@SteKoe @erikpetzold @ulischulte @hzpz can you maybe allow the pipeline to run in the meantime so that we make sure there are no potential issues? Tnx

@vetri15
Copy link
Copy Markdown
Author

vetri15 commented May 24, 2026

Yeah, you were right @cdprete.

I have closed the old PR.

@cdprete
Copy link
Copy Markdown
Contributor

cdprete commented May 24, 2026

By the way, please be aware that there are issues with empty lines.
I don't know if your PR already covers it somehow, but for details have a look at #5388.

@vetri15 vetri15 changed the title Issue 4342 logile view feat(#4342) logfile view - chunk navigation May 24, 2026
@vetri15
Copy link
Copy Markdown
Author

vetri15 commented May 24, 2026

Hi @cdprete,

Thanks for pointing this out. I checked #5388 and updated this PR to handle empty log lines in the logfile view as well.

Empty strings are now rendered as <br> instead of an empty <pre>, so blank lines from the log file are preserved visually. I also brought over the related logfile styling from #5388 for tr, td, br, pre, and logfile links.

@cdprete
Copy link
Copy Markdown
Contributor

cdprete commented May 25, 2026

Hi @cdprete,

Thanks for pointing this out. I checked #5388 and updated this PR to handle empty log lines in the logfile view as well.

Empty strings are now rendered as <br> instead of an empty \<pre\>, so blank lines from the log file are preserved visually. I also brought over the related logfile styling from #5388 for tr, td, br, pre, and logfile links.

Hi @vetri15.

I just wanted to inform you I updated the styles in my PR as follows:

  • removed w-full from pre and br since on tr and td is already enough
  • changed the on-hover target from pre to td to respect also the empty new lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants