Skip to content

Include today's events#2509

Merged
olleolleolle merged 1 commit intomasterfrom
include-todays-events
Feb 26, 2026
Merged

Include today's events#2509
olleolleolle merged 1 commit intomasterfrom
include-todays-events

Conversation

@jonodrew
Copy link
Contributor

This tweaks the DashboardController to include today's events in upcoming. I've checked this works locally - with the main branch, an event running today is not visible. When running this code, it is.

To create a workshop that starts today, you can run

Fabricate(:workshop, date_and_time: Time.zone.now)

from the Rails console

TODO: change the 'upcoming' method to include today, but check first to confirm if that is indeed the behaviour we want

This tweaks the DashboardController to include today's events in upcoming.

TODO: change the 'upcoming' method to include today, but check first to confirm if that is indeed the behaviour we want
Signed-off-by: jonathan.kerr <3410350+jonodrew@users.noreply.github.com>
Copy link
Contributor

@KimberleyCook KimberleyCook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@olleolleolle olleolleolle merged commit 57f2524 into master Feb 26, 2026
14 checks passed
@olleolleolle olleolleolle deleted the include-todays-events branch February 26, 2026 13:57
@ArmandDu
Copy link

Hey, I just logged on the website and now the Dashboard is sorting by oldest first on my side.

By quickly looking at the PRs, this seem the most relevant to the problem. CONTRIBUTING.md doesn't say how to raise an issue. I'll default to commenting here. Please let me know if I should do something else instead.

Issue Description

the workshops in the dashboard page (https://codebar.io/dashboard - requires logged in) are currently sorted by oldest to newest (oldest on top, newest at the bottom of the page).

image (screenshot of the dashboard page. Showing events in 2018 at the top of the page. People's names and venues have been truncated)

Expected Result

The most recent events should be at the top of the page.

Steps to Reproduce

The history of workshops should be displayed.

Comments

My assumption is that this PR is the most likely cause of this change in behavior. I haven't audited the code outside of the PR changes to confirm this assumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants