moved object get into new object function module#175
Merged
raphael-goetz merged 4 commits intomainfrom Apr 23, 2026
Merged
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/taurus/-/pipelines/2475629789 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14066571638/artifacts/out/index.html |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores the missing standard function std::object::get (lost during rebasing per issue #174) by reintroducing an object-field lookup handler in taurus-core, and documenting a dedicated runtime error code for missing keys.
Changes:
- Added
std::object::getto thetaurus-coreobject function registry and implemented the handler. - Added unit tests covering successful
getlookups (string field, nested struct field) and a missing-field case. - Documented new standard error code
T-STD-00002for missing object keys; removed the legacy object function module from the old crate path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| crates/taurus-core/src/runtime/functions/object.rs | Reintroduces std::object::get handler and adds tests for object field retrieval. |
| crates/taurus-core/src/ERROR_CODES.md | Adds T-STD-00002 to the canonical runtime error catalog. |
| crates/core/src/runtime/functions/object.rs | Removes the legacy object function implementation (including the prior get). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #174