implemented taurus emitter pattern#211
Merged
raphael-goetz merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/draco/-/pipelines/2475280200 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/14064113968/artifacts/out/index.html |
Contributor
There was a problem hiding this comment.
Pull request overview
Implements the Taurus “emitter” execution pattern by moving flow execution from a NATS request/response to a publish + per-execution emitter subscription, and updates the REST adapter to map emitter outcomes to HTTP responses.
Changes:
- Add
FlowExecutionResultandexecute_flow_with_emitter()to drive execution viaruntime.emitter.<execution_id>events. - Update REST adapter execution handling to return on first
ongoingevent, treatfailed/transport errors as 500s, and mapfinished(without ongoing) to an empty HTTP response.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| crates/base/src/store.rs | Introduces emitter-based flow execution, event decoding, and new execution result enum. |
| adapter/rest/src/main.rs | Switches REST execution path to use emitter results and adjusts HTTP response mapping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #210