Skip to content

removed any typescript modules/docs#329

Merged
raphael-goetz merged 1 commit intomainfrom
#320-drop-ts
Apr 23, 2026
Merged

removed any typescript modules/docs#329
raphael-goetz merged 1 commit intomainfrom
#320-drop-ts

Conversation

@raphael-goetz
Copy link
Copy Markdown
Member

Resolves: #320

@raphael-goetz raphael-goetz marked this pull request as ready for review April 21, 2026 16:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the repository’s TypeScript “definition reader” package and associated CI/release automation, aligning the repo with Issue #320 (“Drop all TypeScript Packages”).

Changes:

  • Deletes the package/reader TypeScript package (source, config, lockfiles).
  • Removes the TypeScript reader publish job from .github/workflows/release.yml and the TS build job from .github/workflows/ci.yml.
  • Removes the README section documenting TypeScript package installation/usage.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
variant.txt Removes an unused/legacy text artifact.
package/reader/vite.config.ts Deletes Vite build configuration for the removed TS package.
package/reader/tsconfig.json Deletes TypeScript compiler configuration for the removed TS package.
package/reader/src/index.ts Deletes the TS reader implementation.
package/reader/package.json Deletes TS package manifest (publish/build scripts & deps).
package/reader/package-lock.json Deletes lockfile for the removed TS package.
README.md Removes TS package docs section (but still mentions TypeScript elsewhere).
.github/workflows/release.yml Removes TS publish job; leaves tag trigger broad.
.github/workflows/ci.yml Removes TS build job.
Files not reviewed (1)
  • package/reader/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment thread .github/workflows/release.yml
Copy link
Copy Markdown
Member

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏻

@raphael-goetz raphael-goetz merged commit 4dd7328 into main Apr 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop all TypeScript Packages

3 participants