Conversation
# Why Similar to #41739, the `Clipboard.setString()` has been deprecated for a long time. # How Removed the function and corresponding tests. On web, left the legacy behavior fallback as a private API _(we should keep it there because of #17337 (comment) on Safari)_. # Test Plan - Test Suite - Unit tests - NCL # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why Makes it easier to migrate functions taking `Data` / `ByteArray` as arguments into `ArrayBuffer`-like arguments without breaking changes. # How When a function expects `NativeArrayBuffer` or `JavaScriptArrayBuffer` argument, but e.g. `Uint8Array` is passed instead, access its `buffer` property instead of throwing. This also supports partial views, when a typed array is only a view over a subrange of its backing buffer - a copy is performed in such cases (parity with `Uint8Array` convertible) # Test Plan - Unit tests - Manual testing # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
… smart album (#43459) # Why iOS gives us the ability to add or remove assets from the system Favorites smart album through [PHAssetChangeRequest](https://developer.apple.com/documentation/photos/phassetchangerequest/isfavorite), but `expo-media-library` does not implement this. We patched the library for our own use. Opening this PR in case someone else needs this feature too. # How `setAssetFavoriteAsync` takes an asset and a boolean flag. When `true`, it adds the asset to the system "Favorites" smart album; when `false`, it removes it. It returns a boolean indicating whether the operation succeeded. # Test Plan Tested on iOS using the Media Library screen in the `bare-expo` example app. Attaching a screen recording of the feature. https://github.com/user-attachments/assets/aec8515e-f87b-4b9b-a4a7-d6d8164b5315 # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )