Conversation
…ugin removal (#43492) # Why PR #43312 removed the legacy Android plugin in expo-modules-core, and made associated changes to the Gradle scripts in expo-go and in the create-expo-module templates. Because of the potential to break many existing native modules when a project was upgraded to SDK 55, that PR was reverted. However, what we should be doing is reverting only the changes in expo-modules-core, but leaving in place the changes in expo-go and create-expo-module templates that move to the newer Gradle plugin. This way, Expo Go and any new native modules created in future, will correctly use the new plugin. # How Restored only changes in expo-go and in the module templates, leaving expo-modules-core unchanged. # Test Plan CI (including Expo Go CI) should pass
`npm access grant` requires OTP but had no `--otp` flag or retry handling, so grants would silently fail if the OTP expired between publish and grant.
Shared packages like babel-preset-expo, jest-expo, and @expo/config are depended on by nearly every package in the monorepo, so publishing them would cascade a prompt to republish dozens of packages unnecessarily. These packages are now excluded from dependent cascading by default. Use --cascade-all to restore the previous behavior.
Shows which PRs labeled for an SDK version still need cherry-picking to the SDK branch. Detects cherry-picks by matching PR numbers in commit subjects, and publish status by cross-referencing "Publish packages" commits with the packages each PR touched. Usage: et csp [sdk] [--all] [--no-links]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )