Conversation
# Why This PR updates the Android-Image-Cropper dependency to the latest version to close #43396 # How Updated the `com.vanniktech:android-image-cropper` dependency from version 4.6.0 to 4.7.0 # Test Plan - bare expo # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
…ault doesn't apply (#43449) # Why The default `projectRoot` won't be applied to the Metro config in `expo-widgets`, since we alter `config.projectRoot` to be `__dirname`, hence, when this config is loaded only `__dirname` is added. We must add `projectRoot` manually if `@expo/metro-config` hasn't populated the `watchFolders` with a monorepo's `node_modules` folders. # How - Add missing `projectRoot` to `watchFolders` in `expo-widgets/metro.config.js` # Test Plan - Nightly RN build CI task should pass # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
#43453) # Why Fixes [#43444](#43444). The default `create-expo-app` template was showing a `STATUS_BAR_PLUGIN` deprecation warning during `expo prebuild` even though the user never set `androidStatusBar.backgroundColor` in their app config. The root cause was in `withAndroidSplashScreen.ts`: it was automatically setting `config.androidStatusBar.backgroundColor` from the splash screen background color when no `androidStatusBar` config was present. This caused the status bar plugin to pick up the value and emit the deprecation warning (`androidStatusBar.backgroundColor is deprecated and has no effect`). # How Removed the block in `withAndroidSplashScreen.ts` that was auto-populating `config.androidStatusBar.backgroundColor` from the splash background color. Since Android edge-to-edge enforcement makes this property a no-op anyway, there is no reason to keep setting it. Also removed the `expo_splash_screen_status_bar_translucent` string item from `withAndroidSplashStrings.ts`, which was reading from `config.androidStatusBar.translucent` (another deprecated property that no longer has any effect). # Test Plan 1. Build the template: `cd templates/expo-template-bare-minimum && npm pack` 2. Run prebuild: `cd apps/bare-expo && npx expo prebuild --template ../../templates/expo-template-bare-minimum/expo-template-bare-minimum-55.0.14.tgz --clean` 3. Confirm no `STATUS_BAR_PLUGIN` deprecation warning is shown in the output. # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )