Conversation
… Safari swap (#15728) * fix(transitions): prevent WebGL context loss on persist canvas during body swap `swapBodyElement()` previously called `replaceWith()` which detached the old body from the DOM before moving persist elements to the new body. Safari loses WebGL2 context when canvas elements are briefly detached from the DOM tree. The fix lifts persist elements with matching targets to `<html>` before the body swap, so they remain in the DOM throughout the transition. Uses `moveBefore()` where available (Chrome 133+) for zero-detachment atomic moves. Elements without a matching `transition:persist` target in the new page are correctly dropped (not re-inserted). Includes e2e tests for canvas state preservation and orphan cleanup. * addressing the users, avoiding implementation details. --------- Co-authored-by: Martin Trapp <94928215+martrapp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )