[pull] latest from ag-grid:latest#738
Merged
Merged
Conversation
…13808) Avoids unintended early returns that prevented subsequent pin operations from executing when rangeSvc was involved.
* AG-17384-duplicate-grand-total-row-bug
…#13796) * AG-17219 Default pickerButtonBorderRadius to borderRadius theme param Move the borderRadius reference into baseParams so unbordered styles (inputStyleBase) also get themed corner radius — picker buttons have a non-transparent background in baseParams, so corners are visible. Override to 0 in inputStyleUnderlined to keep flat picker buttons in the underlined style. * AG-17219 underlinedInputStyle shouldn't set picker radius to 0
* AG-3390 - Captcha fix (#13750) * Ag 3390 hot sauce campaign (#13764) * AG-3390 - Hot sauce campaign page * AG-3390 - Udpate hot sauce links * AG-3390 - Remove BTP 'more speakers' * AG-3390 - Add agenda DLs to BTP campaign page * AG-3390 - Add agenda DL mobile fix * AG-3390 - Add `urlWithBaseUrl` to btp downloads * AG-3390 - Add `urlWithBaseUrl` for lets cook image * AG-3390 - Update lets cook mobile text sizes * AG-3390 - Update agenda files * AG-3390 - Format agenda json * AG-3390 ignore ics files when linting --------- Co-authored-by: David Skewis <david.skewis@ag-grid.com> * Ag 3390 campaigns updates (#13767) * AG-3390 - Move lets cook page to community * AG-3390 - Update btp agenda .icshttps://github.com/ag-grid/ag-grid/tree/b35.3.0 --------- Co-authored-by: Mark Durrant <mark.j.durrant@gmail.com> Co-authored-by: David Skewis <david.skewis@ag-grid.com>
* AG-3390 - Add scripts to get slack user config * AG-3390 - Generalise slack bot notify and replace agBotSlackMessage slack * AG-3390 - Add error handling to user config request * AG-3390 - Update jira base url * AG-3390 - Add studio to notification settings * AG-3390 - Update secrets names for notion vars * AG-3390 - Do not notify user in website status channel * AG-3390 - Update debug code block message * AG-3390 - Update from github review * AG-3390 - Add gha warning/errors * git subrepo push external/ag-shared subrepo: subdir: "external/ag-shared" merged: "7ba2200cdf8" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "7ba2200cdf8" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "30db3b8" * AG-3390 - Add SYNC-LOG entry for slack CI notification consolidation Document the new shared composite action and slack scripts, the .claude-settings template change, the TypeScript bump, and the per-repo ci.yml migration follow-up required in consumer repos. * git subrepo push external/ag-shared subrepo: subdir: "external/ag-shared" merged: "d5495a68615" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "d5495a68615" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "30db3b8" * AG-3390 - Address Codex review on slack CI notification scripts Fixes three issues flagged on ag-charts#6866 (the downstream ag-shared sync PR), all in shared code shipped by this branch: - getGitChanges: switch range to `lastSuccessfulSha..currentSha` and drop the trailing `head -1` so all commits since the last successful run reach the Slack change list and uniqueUsers (was using `...` symmetric-diff + head -1, which silently collapsed to a single commit). [P1] - getBranchLink: handle GitHub Actions' `refs/pull/<n>/{merge,head}` format (and the bare `pull/<n>` form), extracting the PR number explicitly so the link points at /pull/<n> rather than the raw ref. [P2] - getSlackUserConfig: paginate the Notion data-source query using has_more / next_cursor so the user list stays complete past Notion's default page size. [P2] * Update .gitrepo parent sha * git subrepo pull external/ag-shared subrepo: subdir: "external/ag-shared" merged: "2669b41506d" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "f87feb0cffd" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "5e0f401" * git subrepo push external/ag-shared subrepo: subdir: "external/ag-shared" merged: "12cbf13c673" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "12cbf13c673" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "5e0f401"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )