[pull] latest from ag-grid:latest#736
Merged
Merged
Conversation
* AG-17039 Reorder aggregation function list by usage frequency Order built-in agg funcs as sum, avg, max, min, count, first, last instead of alphabetically. Custom funcs appear after built-ins sorted alphabetically. Use Map for aggFuncsMap and cache the ordered list. * Prevent cache corruption * fix lint
* AG-17270 Fix toolbar pin built-in actions not working when node is null Fall back to iterating over the current range selection for pinTop, pinBottom, and unpinRow actions when triggered from the toolbar (where no row node is provided). * AG-3390 Fix sentinel placement in Jira comment to prevent duplicate comments * AG-3390 Use full sentinel string in duplicate check for robustness * AG-17270 Guard getCellRanges() return value before iterating * AG-17270 Refactor pin action handlers to eliminate duplication * use HOF Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com> --------- Signed-off-by: Victor Musienko <8777372+sdwvit@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )