[pull] latest from ag-grid:latest

.gitignore

@@ -143,4 +143,5 @@ documentation/ag-grid-docs/test-results/.last-run.json
 **/WARP.md
 **/modular-mcp.json
 !.rulesync/.aiignore
+.rulesync/skills/rulesync
 /.junie/

.rulesync/README.md

@@ -4,14 +4,15 @@ Quick-reference for all AI agent commands, skills, sub-agents, and rules availab
 
 ## How It Works
 
-| Folder       | Purpose                                                                  | Loaded by              |
-| ------------ | ------------------------------------------------------------------------ | ---------------------- |
-| `.rulesync/` | Canonical shared source — works across tools (Cursor, Claude Code, etc.) | All supported AI tools |
+| Folder       | Purpose                                                                                           | Loaded by              |
+| ------------ | ------------------------------------------------------------------------------------------------- | ---------------------- |
+| `.rulesync/` | Canonical shared source — works across tools (Cursor, Claude Code, etc.)                          | All supported AI tools |
+| `.claude/`   | Claude Code extensions — mirrors `.rulesync/` plus Claude Code-specific agents, skills, and rules | Claude Code only       |
 
 **Loading behaviour:**
 
 -   **Rules** load automatically based on file-pattern globs (e.g. editing a `.test.ts` file loads the `testing` rule). The root rule (`ag-grid`) loads for all files.
--   **Skills** load on-demand when invoked via `/skill-name`.
+-   **Skills** load on-demand when invoked via `/skill-name`. Skills marked **(user)** are user-invocable only — the LLM should not invoke them autonomously via the Skill tool.
 -   **Sub-agents** are spawned automatically by the AI when a task matches their speciality.
 -   **Commands** are invoked explicitly via `/command-name`.
 
@@ -24,41 +25,40 @@ Quick-reference for all AI agent commands, skills, sub-agents, and rules availab
 
 ## Everyday Development
 
-| Type    | Name                  | Invoke                  | What it does                                       |
-| ------- | --------------------- | ----------------------- | -------------------------------------------------- |
-| Command | 🔵 `/code-fixup`      | `/code-fixup <package>` | Fix build and lint errors across a package         |
-| Command | 🔵 `/code-cleanup`    | `/code-cleanup`         | Remove bloat, duplication; improve clarity         |
-| Command | 🔵 `/pr-create`       | `/pr-create`            | Commit, push, and open a PR                        |
-| Command | 🔵 `/pr-review`       | `/pr-review <PR#>`      | Review a PR (Markdown output)                      |
-| Command | 🔵 `/pr-review-json`  | `/pr-review-json <PR#>` | Review a PR (JSON for inline comments)             |
-| Skill   | 🟢 `dev-server`       | `/dev-server`           | Start dev server, check build status               |
-| Skill   | 🔵 `git-conventions`  | `/git-conventions`      | Branch, commit, and PR naming conventions          |
-| Skill   | 🟢 `technology-stack` | `/technology-stack`     | Architecture constraints and zero-dependency rules |
-| Agent   | 🔵 `code-reviewer`    | Auto (after edits)      | Quality, security, and maintainability review      |
+| Type  | Name                  | Invoke                             | What it does                                       |
+| ----- | --------------------- | ---------------------------------- | -------------------------------------------------- |
+| Skill | 🔵 `code-fixup`       | `/code-fixup <package>` (user)     | Fix build and lint errors across a package         |
+| Skill | 🔵 `code-cleanup`     | `/code-cleanup` (user)             | Remove bloat, duplication; improve clarity         |
+| Skill | 🔵 `pr-create`        | `/pr-create` (user)                | Commit, push, and open a PR                        |
+| Skill | 🔵 `pr-review`        | `/pr-review [--json] <PR#>` (user) | Review a PR (Markdown default, JSON with `--json`) |
+| Skill | 🟢 `dev-server`       | `/dev-server`                      | Start dev server, check build status               |
+| Skill | 🔵 `git-conventions`  | `/git-conventions`                 | Branch, commit, and PR naming conventions          |
+| Skill | 🟢 `technology-stack` | `/technology-stack`                | Architecture constraints and zero-dependency rules |
+| Agent | 🔵 `code-reviewer`    | Auto (after edits)                 | Quality, security, and maintainability review      |
 
 ## Testing and Quality
 
-| Type    | Name                     | Invoke                | What it does                                   |
-| ------- | ------------------------ | --------------------- | ---------------------------------------------- |
-| Command | 🔵 `/git-bisect`         | `/git-bisect`         | Find the commit that introduced a regression   |
-| Command | 🔵 `/batch-lint-cleanup` | `/batch-lint-cleanup` | Auto-fix ESLint violations by rule             |
-| Command | 🟢 `/docs-e2e-tests`     | `/docs-e2e-tests`     | Write/update Playwright tests for doc examples |
-| Agent   | 🔵 `playwright-expert`   | Auto                  | Playwright test architecture and debugging     |
+| Type    | Name                    | Invoke                       | What it does                                   |
+| ------- | ----------------------- | ---------------------------- | ---------------------------------------------- |
+| Skill   | 🔵 `git-bisect`         | `/git-bisect` (user)         | Find the commit that introduced a regression   |
+| Skill   | 🔵 `batch-lint-cleanup` | `/batch-lint-cleanup` (user) | Auto-fix ESLint violations by rule             |
+| Command | 🟢 `/docs-e2e-tests`    | `/docs-e2e-tests`            | Write/update Playwright tests for doc examples |
+| Agent   | 🔵 `playwright-expert`  | Auto                         | Playwright test architecture and debugging     |
 
 ## Planning and Analysis
 
-| Type    | Name                             | Invoke                        | What it does                                     |
-| ------- | -------------------------------- | ----------------------------- | ------------------------------------------------ |
-| Command | 🔵 `/plan-review`                | `/plan-review`                | Review plans for completeness and correctness    |
-| Command | 🔵 `/plan-implementation-review` | `/plan-implementation-review` | Review plan execution, identify delivery gaps    |
-| Agent   | 🔵 `nx-expert`                   | Auto                          | Nx monorepo configuration and build optimisation |
+| Type  | Name                            | Invoke                               | What it does                                     |
+| ----- | ------------------------------- | ------------------------------------ | ------------------------------------------------ |
+| Skill | 🔵 `plan-review`                | `/plan-review` (user)                | Review plans for completeness and correctness    |
+| Skill | 🔵 `plan-implementation-review` | `/plan-implementation-review` (user) | Review plan execution, identify delivery gaps    |
+| Agent | 🔵 `nx-expert`                  | Auto                                 | Nx monorepo configuration and build optimisation |
 
-## Context and Memory
+## Memory
 
-| Type    | Name           | Invoke      | What it does                                       |
-| ------- | -------------- | ----------- | -------------------------------------------------- |
-| Command | 🔵 `/remember` | `/remember` | Save branch context or project learnings as memory |
-| Command | 🔵 `/recall`   | `/recall`   | Load branch context and browse project memory      |
+| Type  | Name          | Invoke             | What it does                                       |
+| ----- | ------------- | ------------------ | -------------------------------------------------- |
+| Skill | 🔵 `remember`  | `/remember` (user) | Save branch context or project learnings as memory |
+| Skill | 🔵 `recall`    | `/recall` (user)   | Load branch context, browse project memories       |
 
 ## Documentation Review
 
@@ -69,11 +69,12 @@ Quick-reference for all AI agent commands, skills, sub-agents, and rules availab
 
 ## Git and Branch Management
 
-| Type    | Name                     | Invoke                | What it does                             |
-| ------- | ------------------------ | --------------------- | ---------------------------------------- |
-| Command | 🔵 `/git-worktree-clean` | `/git-worktree-clean` | Hard-reset worktree to `origin/latest`   |
-| Command | 🔵 `/git-split`          | `/git-split`          | Split large files preserving git history |
-| Command | 🔵 `/pr-split`           | `/pr-split`           | Split a branch into stacked PRs          |
+| Type  | Name                    | Invoke                       | What it does                             |
+| ----- | ----------------------- | ---------------------------- | ---------------------------------------- |
+| Skill | 🔵 `sync-ag-shared`     | `/sync-ag-shared` (user)     | Sync ag-shared subrepo across AG repos   |
+| Skill | 🔵 `git-worktree-clean` | `/git-worktree-clean` (user) | Hard-reset worktree to `origin/latest`   |
+| Skill | 🔵 `git-split`          | `/git-split` (user)          | Split large files preserving git history |
+| Skill | 🔵 `pr-split`           | `/pr-split` (user)           | Split a branch into stacked PRs          |
 
 ---
 
@@ -113,11 +114,25 @@ Rules load automatically when you edit files matching their glob patterns.
 
 Skills load on-demand when invoked. All skills are invoked via `/skill-name`. All skills are shared across AI tools via `.rulesync/skills/`.
 
-| Skill                 | Description                                               |
-| --------------------- | --------------------------------------------------------- |
-| 🟢 `dev-server`       | Start dev server, check build status                      |
-| 🔵 `git-conventions`  | Branch, commit, and PR naming conventions                 |
-| 🟢 `technology-stack` | Architecture constraints and zero-dependency requirements |
+| Skill                           | Description                                               |
+| ------------------------------- | --------------------------------------------------------- |
+| 🔵 `batch-lint-cleanup`         | Auto-fix ESLint violations by rule                        |
+| 🔵 `code-cleanup`               | Remove bloat, duplication; improve clarity                |
+| 🔵 `code-fixup`                 | Fix build and lint errors across a package                |
+| 🟢 `dev-server`                 | Start dev server, check build status                      |
+| 🔵 `git-bisect`                 | Find the commit that introduced a regression              |
+| 🔵 `git-conventions`            | Branch, commit, and PR naming conventions                 |
+| 🔵 `git-split`                  | Split large files preserving git history                  |
+| 🔵 `git-worktree-clean`         | Hard-reset worktree to `origin/latest`                    |
+| 🔵 `plan-implementation-review` | Review plan execution, identify delivery gaps             |
+| 🔵 `plan-review`                | Review plans for completeness and correctness             |
+| 🔵 `pr-create`                  | Commit, push, and open a PR                               |
+| 🔵 `pr-review`                  | Review a PR (Markdown default, JSON with `--json`)        |
+| 🔵 `pr-split`                   | Split a branch into stacked PRs                           |
+| 🔵 `recall`                     | Load branch context, browse project memories              |
+| 🔵 `remember`                   | Save branch context or project learnings as memory        |
+| 🔵 `sync-ag-shared`             | Sync ag-shared subrepo changes across AG repos            |
+| 🟢 `technology-stack`           | Architecture constraints and zero-dependency requirements |
 
 ---
 

.rulesync/skills/batch-lint-cleanup

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/batch-lint-cleanup/

.rulesync/skills/code-cleanup

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/code-cleanup/

.rulesync/skills/code-fixup

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/code-fixup/

.rulesync/skills/git-bisect

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/git-bisect/

.rulesync/skills/git-split

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/git-split/

.rulesync/skills/git-worktree-clean

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/git-worktree-clean/

.rulesync/skills/plan-implementation-review

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/plan-implementation-review/

.rulesync/skills/plan-review

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/plan-review/

.rulesync/skills/pr-create

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/pr-create/

.rulesync/skills/pr-review

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/pr-review/

.rulesync/skills/pr-split

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/pr-split/

.rulesync/skills/recall

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/recall/

.rulesync/skills/remember

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/remember/

.rulesync/skills/sync-ag-shared

@@ -0,0 +1 @@
+../../external/ag-shared/prompts/skills/sync-ag-shared/

.vscode/extensions.json

@@ -12,8 +12,6 @@
     "syler.sass-indented",
     // shows the cost of each import
     "wix.vscode-import-cost",
-    // shows the cost of CSS properties
-    "kisstkondoros.csstriggers",
     // es6 string HTML highlight
     "tobermory.es6-string-html",
     // prettier

external/ag-shared/.gitrepo

@@ -6,7 +6,7 @@
 [subrepo]
 	remote = https://github.com/ag-grid/ag-shared.git
 	branch = latest
-	commit = 4d82650c622e0433d9b58410adc1c88a00608f9d
-	parent = e95f2f1e806d05dad1435a1336724ed0b7d9c0e6
+	commit = a359ab89a52dee65475a46b6ddd81ef82943f079
+	parent = 18f4aceb6c6fc2f7cc446bf315f9b03c24d083de
 	method = rebase
 	cmdver = 0.4.9

external/ag-shared/github/actions/codex-pr-review/action.yml

@@ -40,7 +40,7 @@ inputs:
     prompt-file:
         description: 'Path to the prompt file'
         required: false
-        default: 'external/ag-shared/prompts/commands/pr/review.md'
+        default: 'external/ag-shared/prompts/skills/pr-review/SKILL.md'
     github-token:
         description: 'GitHub token for PR access and commenting'
         required: true
@@ -278,12 +278,11 @@ runs:
           id: prompt
           shell: bash
           run: |
-              # Use JSON prompt if inline comments enabled, otherwise use configured prompt
+              # Use same prompt file for both modes; JSON mode is controlled via --json in ARGUMENTS
+              prompt_file="${{ inputs.prompt-file }}"
               if [[ "${{ inputs.inline-comments }}" == "true" ]]; then
-                prompt_file="external/ag-shared/prompts/commands/pr/review-json.md"
                 output_ext="json"
               else
-                prompt_file="${{ inputs.prompt-file }}"
                 output_ext="md"
               fi
               echo "prompt_file=${prompt_file}" >> $GITHUB_OUTPUT
@@ -296,7 +295,7 @@ runs:
           env:
               OPENAI_API_KEY: ${{ inputs.codex-api-key }}
               CODEX_API_KEY: ${{ inputs.codex-api-key }}
-              ARGUMENTS: ${{ inputs.pr-number }}
+              ARGUMENTS: ${{ inputs.inline-comments == 'true' && format('--json {0}', inputs.pr-number) || inputs.pr-number }}
               BASE_REF: ${{ inputs.base-ref }}
               HEAD_REF: ${{ inputs.head-ref }}
               PR_TITLE: ${{ inputs.pr-title }}