[pull] master from mozilla:master#388
Merged
Merged
Conversation
Enable the recommended preset and fix or per-line-disable the 78 findings it surfaces. Most are equivalent rewrites, intentional patterns (control chars, the whatwg email regex, autolinker URL regex) keep their behavior via targeted disables.
…ptor and add font substitutions for the standard Acrobat CJK families.
Avoid a temporary variable and return results directly in a couple of functions
Load the predefined CMap for composite fonts that omit the FontDescriptor
…t tests When a reftest hangs and trips the per-browser timeout, the session was closed, which left every remaining task in the per-browserType queue with no consumer and effectively skipped the rest of the manifest. Instead, mark the in-flight task(s) as failed, reload the page so the driver can reconnect and request the next task, and only fall back to closing the session if the reload itself fails.
Enable 'eslint-plugin-regexp' and fix existing findings
Recover the browser session on test timeout to keep running subsequent tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )