[pull] master from mozilla:master#385
Merged
Merged
Conversation
Some Type1 fonts (the embedded Optima variants in orw1972.pdf) ship two /Subrs and /CharStrings blocks wrapped in save/restore frames gated on an Adobe hires/lores runtime switch. In such cases, we just use the first /Subrs and /CharStrings block, which is the one that is actually used by the font renderer in Acrobat. It fixes #18548.
Keep the first /Subrs and /CharStrings block
It fixes #7625. If the Top DICT's Private DICT extends past the end of the font data, the Local Subrs INDEX is unreachable and every CharString that calls a subr ends up as a blank glyph. Throw from parsePrivateDict so the existing catch in translateFont triggers fallbackToSystemFont, then run getFontSubstitution post-construction so we pick a close local match instead of the generic fallbackName.
Substitute a system font when an embedded CFF is truncated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )