[pull] master from mozilla:master#384
Merged
Merged
Conversation
Given that the "print" intent is handled separately, there's currently a little bit of unnecessary code duplication in this method.
…tor.js` file When comparing this code with the full `XRef` class it doesn't seem to be entirely correctly implemented, since the `fetch` method is basically doing what the `fetchIfRef` method is intended to do.
Rather than effectively duplicating code, we can use a loop instead.
…ndency_tracker.js` In many/most PDF documents every glyph will require that the character BBox has scaling/offset applied, which can be made a tiny bit more efficient. In particular: - Avoid creating one additional temporary Array for every glyph. - Simplify the helper function, since there's no skew-components.
Shorten the `fontFile` lookup a tiny bit
…horten Shorten the `XfaLayerBuilder.prototype.render` method
…omBase64 Use `Uint8Array.fromBase64` in the `test/integration/highlight_editor_spec.mjs` file
Simplify how the character BBox is scaled in `src/display/canvas_dependency_tracker.js`
Add support for Optional Content in the AnnotationLayer (issue 20433)
Fix the `XRefWrapper` implementation, in the `src/core/editor/pdf_editor.js` file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )