[pull] master from mozilla:master#376
Merged
Merged
Conversation
…tests The custom solution for obtaining the bounding box of a given element that we have now was necessary during the original introduction of the integration tests because at the time the `ElementHandle.boundingBox()` API in Puppeteer didn't work correctly in Chrome. However, `getRect`, where this is used, is a hot utility function because most tests call it multiple times, either directly or indirectly via other utility functions, and it turns out that the approach we use is slower than the native `ElementHandle.boundingBox()` API. Fortunately, most likely after a combination of Chrome/Puppeteer updates and the conversion to the formalized WebDriver BiDi protocol the custom solution is no longer necessary because all tests pass without it too, so this commit converts `getRect` to use `ElementHandle.boundingBox()` instead to speed up the tests.
Originally we introduced a small delay for Puppeteer operations in Chrome to avoid intermittent failures where protocol calls were happening too quickly in succession. However, since then a number of improvements were made, both locally and upstream, that reduce the need for this delay: - the integration tests have been hardened to remove (potential) sources of intermittent failures in many places; - the browsers and Puppeteer have been updated to improve performance and support for testing infrastructure; - the conversion to WebDriver BiDi has been completed, which replaced the Chrome-specific CDP protocol with a formalized protocol that could provide more safety guarantees. This commit therefore reduces the Chrome-specific delay from 5 to 3 milliseconds, which should nowadays be a better value to speed up the Chrome tests and bring them closer to Firefox in terms of runtime.
This caused the tab to remain open after the tests ran, which meant that a total of ~120 MB of memory was not being freed.
…ing` integration test on Windows It looks like this test passes consistently again, most likely after a combination of browser/Puppeteer/configuration updates and the completed switch to the WebDriver BiDi protocol. Fixes #20136.
…le in the `PDFDocumentProperties` dialog
…def-contentLength-test Add an integration-test for documents without `contentLength` available in the `PDFDocumentProperties` dialog
Enable the `must check that an existing highlight is ignored on hovering` integration test on Windows
Optimize runtime and memory usage of the integration tests
It fixes the issue #20633.
Recover CFF private dict defaults zeroed by Ghostscript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )