Archived tasks don't need task lists or order#1155
Merged
Conversation
joshsmith
force-pushed
the
1150-1154-archived-tasks-dont-need-lists-or-order
branch
from
02423b3 to
a8d5f7c
Compare
snewcomer
reviewed
Nov 6, 2017
|
|
||
| # We really want to test the order is set, but we have no good way to | ||
| # test this since the column default is `0` | ||
| assert order !== 0 |
Contributor
There was a problem hiding this comment.
Ah so assert order fails. Would have thought since refute only handles nil and false that assert would have worked! 🚶♂️
Contributor
Author
There was a problem hiding this comment.
assert order succeeds but that's insufficient to tell us anything. Since the default is 0 it could just be set to 0, but instead it will receive a random ranked value from EctoOrdered.
snewcomer
approved these changes
Nov 6, 2017
joshsmith
deleted the
1150-1154-archived-tasks-dont-need-lists-or-order
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
:archivedcasting up intochangesetsince it can happen on creation (e.g. importing from GitHub)task_list_idororderwhen archivedtask_list_idto only the case when task is not archivedReferences
Fixes #1150
Fixes #1154