Skip to content

Comments

Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5#95

Merged
clue merged 1 commit intoclue:1.xfrom
clue-labs:phpunit8
Feb 21, 2026
Merged

Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5#95
clue merged 1 commit intoclue:1.xfrom
clue-labs:phpunit8

Conversation

@clue
Copy link
Owner

@clue clue commented Feb 21, 2026

This changeset updates the test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5. This is needed to run the tests on legacy platforms due to recent upstream changes as discussed in clue/reactphp-redis#180.

Builds on top of clue/reactphp-redis#180 and #66 and others

@clue clue added this to the v1.6.0 milestone Feb 21, 2026
@clue clue requested a review from Copilot February 21, 2026 20:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the test environment to support PHP 7.2 by adding PHPUnit 8.5 to the dependency constraints and simplifying the CI workflow configuration. Previously, PHP 7.2 fell into a gap where it couldn't use PHPUnit 9.6 (which requires PHP >= 7.3) and had to fall back to the older PHPUnit 5.7. This change fills that gap by adding PHPUnit 8.5, which is compatible with PHP 7.2-7.4.

Changes:

  • Added PHPUnit 8.5 to the version constraint in composer.json to support PHP 7.2
  • Simplified CI workflow by consolidating two conditional test execution steps into a single step with inline conditional logic

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
composer.json Added ^8.5 to PHPUnit version constraints to enable PHPUnit 8.5 for PHP 7.2
.github/workflows/ci.yml Simplified test execution by using inline conditional expression instead of separate conditional steps

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@clue clue merged commit 68d1271 into clue:1.x Feb 21, 2026
19 checks passed
@clue clue deleted the phpunit8 branch February 21, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant