Update test suite to ensure 100% code coverage#37
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to enforce and advertise 100% code coverage by adding CI enforcement, documenting local coverage generation, and excluding an environment-specific line from coverage.
Changes:
- Add a CI step that fails the build unless statement coverage is 100%.
- Add a README badge and testing docs describing 100% coverage expectations and local coverage reporting.
- Mark a PHP-version-dependent line in
Encoderas ignored for coverage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Encoder.php |
Adds a @codeCoverageIgnore annotation for a PHP version-specific code path. |
README.md |
Adds a 100% coverage badge and documents how to generate coverage locally. |
.github/workflows/ci.yml |
Adds a CI step intended to enforce 100% coverage by parsing a Clover XML report. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #35, #26 and clue/reactphp-eventsource#35