Run tests on PHP 8.5 and update test environment#43
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the test environment and CI configuration to support PHP 8.5 and improve compatibility with recent PHP versions. It builds upon several related PRs that improve PHP 8.4+ support and fix test environment issues on legacy PHP versions.
Changes:
- Modified reflection property access in tests to be compatible with PHP 8.1+ by conditionally calling
setAccessible()only for PHP < 8.1 - Updated dependency versions for
react/event-loop,react/promise, andreact/socketto newer versions with PHP 8.5 support - Added PHP 8.5 to the CI test matrix and updated GitHub Actions checkout action to v6
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ConnectionManagerTimeoutTest.php | Added PHP version check to conditionally call setAccessible() only for PHP < 8.1 |
| tests/ConnectionManagerDelayTest.php | Added PHP version check to conditionally call setAccessible() only for PHP < 8.1 |
| composer.json | Updated dependency versions for event-loop (^1.6), promise (^3.3), and socket (^1.17) to support PHP 8.5 |
| .github/workflows/ci.yml | Added PHP 8.5 to test matrix and updated actions/checkout to v6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #41, #42, reactphp/socket#325, reactphp/promise#264, reactphp/event-loop#282, and clue/framework-x#297