chore: Apply flashbar new style in one-theme#4671
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4671 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 948 948
Lines 30491 30492 +1
Branches 11151 11151
=======================================
+ Hits 29751 29752 +1
- Misses 693 733 +40
+ Partials 47 7 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| colorBorderItemFocused: '{colorTextNotificationYellow}', | ||
|
|
||
| // Dismiss button | ||
| colorTextInteractiveInvertedDefault: '{colorNeutral650}', |
There was a problem hiding this comment.
I don't understand why this existed before and we're removing it now.
There was a problem hiding this comment.
It's actually not a true removal but it's retargeted. The flashbar-icon button variant was switched from the inverted interactive tokens to the plain colorTextInteractive* ones in the constants.scss.
So the warning override had to move from ...InvertedDefault/Hover to ...Default/Hover the inverted overrides are now dead.
The warning flash is light in both modes, so we still pin to colorNeutral650/950 for dismiss-icon contrast.
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.