Skip to content

chore: Apply flashbar new style in one-theme#4671

Merged
at-susie merged 11 commits into
mainfrom
onetheme/flashbar-new-style
Jul 1, 2026
Merged

chore: Apply flashbar new style in one-theme#4671
at-susie merged 11 commits into
mainfrom
onetheme/flashbar-new-style

Conversation

@at-susie

Copy link
Copy Markdown
Member

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.57%. Comparing base (6a213a0) to head (0b607b7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4671   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         948      948           
  Lines       30491    30492    +1     
  Branches    11151    11151           
=======================================
+ Hits        29751    29752    +1     
- Misses        693      733   +40     
+ Partials       47        7   -40     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

colorBorderItemFocused: '{colorTextNotificationYellow}',

// Dismiss button
colorTextInteractiveInvertedDefault: '{colorNeutral650}',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this existed before and we're removing it now.

@at-susie at-susie Jun 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually not a true removal but it's retargeted. The flashbar-icon button variant was switched from the inverted interactive tokens to the plain colorTextInteractive* ones in the constants.scss.

So the warning override had to move from ...InvertedDefault/Hover to ...Default/Hover the inverted overrides are now dead.

The warning flash is light in both modes, so we still pin to colorNeutral650/950 for dismiss-icon contrast.

Comment thread src/flashbar/styles.scss
@at-susie at-susie added this pull request to the merge queue Jul 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 1, 2026
@at-susie at-susie added this pull request to the merge queue Jul 1, 2026
Merged via the queue into main with commit f91a59e Jul 1, 2026
51 checks passed
@at-susie at-susie deleted the onetheme/flashbar-new-style branch July 1, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants