add snapshot create delete capability#111
Draft
disperate wants to merge 69 commits intocloudscale-ch:masterfrom
Draft
add snapshot create delete capability#111disperate wants to merge 69 commits intocloudscale-ch:masterfrom
disperate wants to merge 69 commits intocloudscale-ch:masterfrom
Conversation
…dd-snapshot-create-delete-capability
mweibel
reviewed
Jan 22, 2026
Collaborator
mweibel
left a comment
There was a problem hiding this comment.
looks good so far. I have a few questions and mostly nits.
For reviewers sake: it would be great to have an example in the examples folder ready to use for testing this. I currently didn't test it on a cluster although I did install the version to see if it starts and if we have any immediate error logs (we don't).
Co-authored-by: Michael Weibel <307427+mweibel@users.noreply.github.com>
….com:disperate/csi-cloudscale into julian/add-snapshot-create-delete-capability
… TestPod_Create_Volume_From_Snapshot, remove unused client param
add snapshot list capability
fix multiple snapshots bug
…an/handle-snapshot-limit
…si-cloudscale into julian/handle-snapshot-limit
handle snapshot limit
…creation-from-snapshot resize volume on creation if requested size is bigger than snapshot
resize volume on creation if requested size is bigger than snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
ControllerServiceCapability_RPC_CREATE_DELETE_SNAPSHOT.