ci: run Go unit tests for the maintenance module#238
Open
mnencia wants to merge 3 commits into
Open
Conversation
mnencia
force-pushed
the
dev/ci-unit-tests
branch
from
6f74aa2 to
074d5e6
Compare
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
NiccoloFei
force-pushed
the
dev/ci-unit-tests
branch
from
074d5e6 to
da41427
Compare
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
NiccoloFei
approved these changes
Jun 9, 2026
GabriFedi97
reviewed
Jun 10, 2026
| @@ -0,0 +1,54 @@ | |||
| name: Unit tests | |||
Contributor
There was a problem hiding this comment.
Suggested change
| name: Unit tests | |
| name: Dagger Module Unit tests |
| pull_request: | ||
| paths: | ||
| - 'dagger/maintenance/**' | ||
| workflow_dispatch: |
Contributor
There was a problem hiding this comment.
Do we really need workflow_dispatch here?
| { | ||
| "name": "maintenance", | ||
| "engineVersion": "v0.20.6", | ||
| "engineVersion": "v0.21.4", |
Contributor
There was a problem hiding this comment.
would be worth tracking this version with renovate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maintenance module under
dagger/maintenancehas unit tests but nothing in CI runs them. This adds a workflow that runsgo teston every pull request and on pushes tomain.The generated Dagger client (
internal/dagger,dagger.gen.go) is gitignored, so the workflow runsdagger developto regenerate it before testing. The generated client panics at init unlessDAGGER_SESSION_PORTandDAGGER_SESSION_TOKENare set; the unit tests never open a session, so dummy values are enough to get past that check without contacting an engine.