Remove AdobeStockImage dependency#141
Open
alinalexandru wants to merge 679 commits intocloudinary:masterfrom
Open
Remove AdobeStockImage dependency#141alinalexandru wants to merge 679 commits intocloudinary:masterfrom
alinalexandru wants to merge 679 commits intocloudinary:masterfrom
Conversation
v1.15.1: Bumped version to 1.15.1
…n instead of the config observer
… support Magento v2.4^
add: GraphQL support for query Cld images
…d for jqueryui/widget
…-using-froogaloop2-min-js-MAG-799 CLOUDINARY-381 504 when using froogaloop2.min.js
RonenGiritCloudinary
force-pushed
the
master
branch
from
317f0fd to
2ec9f57
Compare
RonenGiritCloudinary
force-pushed
the
master
branch
from
2ec9f57 to
d5e8519
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extending an XML file, there is no need to copy existing setting.
Even though Adobe Stock Image is now part of magento default meta-package, It can be removed in order to increase magento performance.
<columns name="media_gallery_columns">is already defined in https://github.com/magento/adobe-stock-integration/blob/develop/AdobeStockImageAdminUi/view/adminhtml/ui_component/media_gallery_listing.xml and there is no need to have those settings in the cloudinary module.With this PR, the magento2 module will work correctly no mather if Adobe Stock Image module exists or not.