Skip to content

fix: Prometheus Metrics endpoint is always enabled because ha_proxy.stats_promex_enable is not checked properly #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a18e wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

fix: Prometheus Metrics endpoint is always enabled because ha_proxy.stats_promex_enable is not checked properly #901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jobs/haproxy/templates/haproxy.config.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ listen stats
acl private src <%= p("ha_proxy.trusted_stats_cidrs") %>
http-request deny unless private
mode http
<%- if_p("ha_proxy.stats_promex_enable") do -%>
<%- if p("ha_proxy.stats_promex_enable") -%>
http-request use-service prometheus-exporter if { path <%= p("ha_proxy.stats_promex_path") %> }
<%- end -%>
stats enable
Expand Down
6 changes: 6 additions & 0 deletions spec/haproxy/templates/haproxy_config/stats_listener_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@
end
end

context 'when ha_proxy.stats_promex_enable is false (default)' do
it 'does not include a prometheus exporter endpoint' do
expect(stats_listener).not_to include(a_string_including('prometheus-exporter'))
end
end

context 'when ha_proxy.trusted_stats_cidrs is set' do
let(:properties) do
default_properties.merge({ 'trusted_stats_cidrs' => '1.2.3.4/32' })
Expand Down