Skip to content

fix: support IPv6 when joining IP address and port#881

Merged
plowin merged 1 commit intomasterfrom
correctly-handle-IPv4+IPv6
Feb 26, 2026
Merged

fix: support IPv6 when joining IP address and port#881
plowin merged 1 commit intomasterfrom
correctly-handle-IPv4+IPv6

Conversation

@plowin
Copy link
Contributor

@plowin plowin commented Feb 26, 2026

Fixes unit-test issues from #880.

More stricter rules were introduced with go 1.25:

The New "hostport" Analyzer: Go 1.25 introduces hostport, which reports uses of fmt.Sprintf("%s:%d", host, port) (or similar string splicing) to construct network addresses for net.Dial.

Copy link
Contributor

@b1tamara b1tamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Application Runtime Platform Working Group Feb 26, 2026
@plowin plowin merged commit 7de1ad8 into master Feb 26, 2026
4 checks passed
@plowin plowin deleted the correctly-handle-IPv4+IPv6 branch February 26, 2026 13:05
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Application Runtime Platform Working Group Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-ci Allow this PR to be tested on Concourse

Projects

Development

Successfully merging this pull request may close these issues.

2 participants