Skip to content

Add BOSH properties for Locket DB health check.#1111

Open
rositsa-popova wants to merge 1 commit intocloudfoundry:developfrom
rositsa-popova:add-locket-db-health-check-properties
Open

Add BOSH properties for Locket DB health check.#1111
rositsa-popova wants to merge 1 commit intocloudfoundry:developfrom
rositsa-popova:add-locket-db-health-check-properties

Conversation

@rositsa-popova
Copy link

@rositsa-popova rositsa-popova commented Mar 4, 2026

Summary

Adds BOSH job properties to configure the Locket database health check feature implemented in cloudfoundry/locket#XXX (PR number)

Resolves: #1105

New Properties:

  • diego.locket.enable_db_health_check - Feature flag (default: false)
  • diego.locket.health_check_interval - Check frequency (default: 10 seconds)
  • diego.locket.health_check_timeout - Check timeout (default: 5 seconds)
  • diego.locket.health_check_failure_threshold - Failures before restart (default: 3)

Related Work:

Test Results

Tested on dev landscape with Cloud Foundry deployment:

  • Test 1: Default disabled, no behavior change
  • Test 2: Properties correctly templated, health checks run every 10s
  • Test 3: Detected database failure, auto-restart works
  • Test 4: Timeout configuration works correctly
  • Test 5: All property values applied correctly with time units

Deployment Example

instance_groups:
- name: diego-api
  jobs:
  - name: locket
    properties:
      diego:
        locket:
          enable_db_health_check: true
          health_check_interval: 10
          health_check_timeout: 5
          health_check_failure_threshold: 3

Backward Compatibility

Breaking Change? No

All properties have safe defaults and the feature is disabled by default. Operators can upgrade without manifest changes. Health check can be enabled after upgrade via configuration-only deployment.

@rositsa-popova rositsa-popova requested a review from a team as a code owner March 4, 2026 08:31
@linux-foundation-easycla
Copy link

CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant