Fix sporadic test failure in service broker deletion during creation#5045
Merged
philippthun merged 1 commit intocloudfoundry:mainfrom Apr 20, 2026
Conversation
The test was flaky because both create and delete jobs could be enqueued with the same timestamp, making pickup order non-deterministic. When the delete job ran first, the create job failed with ServiceBrokerGone. Fix by setting a higher priority number for the delete job so the create job always runs first.
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Apr 20, 2026
Changes in cloud_controller_ng:
- Fix sporadic test failure in service broker deletion during creation
PR: cloudfoundry/cloud_controller_ng#5045
Author: Philipp Thun <philipp.thun@sap.com>
- Fix race condition in route destination updates
PR: cloudfoundry/cloud_controller_ng#4945
Author: Philipp Thun <philipp.thun@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was flaky because both create and delete jobs could be enqueued with the same timestamp, making pickup order non-deterministic. When the delete job ran first, the create job failed with
ServiceBrokerGone.Fix by setting a higher priority number for the delete job so the create job always runs first.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests