Merge jammy#582
Closed
aramprice wants to merge 28 commits intoubuntu-noblefrom
Closed
Conversation
In https://lists.ubuntu.com/archives/jammy-changes/2024-September/033387.html it says: " Packaging restructuring: - Split netplan-generator into separate package to make the Python dependency optional. - Split python3-netplan bindings into a separate package" Newer Azure builds pull in this new netplan version due to cloud-init. It does not seem like there are any functional changes that we care about. ai-assisted=yes [TNZ-88995]
We don't really ever want these builds to stack up, and I believe the attempts: 3 just lead to longer failure cycles. ai-assisted=yes [TNZ-88995]
Include netplan refactor packages in Azure dpkg list
…uilder Serialize stemcell builds, and remove attempts
The new error checking was finding errors. Going back to the old code which did not check for errors but did work for teams. Jammy-on-Jammy -on-Garden is a pretty niche use case these days, so this seems ok.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- set explicitly in pipeline config
- delete unused *.meta4 files - delete *.meta4 files for unsupported stemcells
Remove conditional path in CI that could download the OS_IMAGE using `meta4 file-download`. Remove rake tasks which supported this path, and remove references from docs.
Move metalink files to repo root
|
Important Review skippedToo many files! This PR contains 155 files, which is 5 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (155)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Member
Author
|
Attempting to recreate with correct base |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges forward OS-image/stemcell-builder changes and standardizes how Ubuntu OS image metalinks are stored and consumed by CI, while removing the old “download remote OS image during stemcell build” flow.
Changes:
- Add/update OS-image metalinks under
image-metalinks/<branch>/(including new noble + jammy entries) and remove the old PoC metalink location. - Update CI tasks/pipeline to treat
os-image-tarballas a required input and to read metalinks from the repo-rootimage-metalinks/path. - Simplify rake tasks by removing
stemcell:download_os_image/stemcell:build_with_local_os_imageand makingstemcell:buildrequire anos_image_path.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| image-metalinks/ubuntu-noble/ubuntu-noble.meta4 | Adds noble OS-image + usn-log metalink metadata at the repo-root location. |
| image-metalinks/ubuntu-jammy/ubuntu-jammy.meta4 | Adds jammy OS-image + usn-log metalink metadata at the repo-root location. |
| ci/tasks/os-images/build.sh | Updates permissions/flow for OS-image build and relies on repo-root layout. |
| ci/tasks/build.yml | Makes os-image-tarball a required input to the stemcell build task. |
| ci/tasks/build.sh | Always uses a local OS image tarball and calls the unified stemcell:build task. |
| ci/tasks/build-release-metadata.sh | Fixes metalink path to repo-root image-metalinks/<branch>/.... |
| ci/pipelines/builder.yml | Updates metalink resource URI/path and meta4 naming to include agent_suffix. |
| bosh-stemcell/spec/assets/dpkg-list-ubuntu-azure-additions.txt | Updates expected Azure package additions list. |
| bosh-stemcell/image-metalinks/ubuntu_noble_poc/ubuntu-noble.meta4 | Removes obsolete PoC metalink file. |
| Rakefile | Removes remote download/build-with-local split; stemcell:build now requires os_image_path. |
| README.md | Updates docs to use the unified stemcell:build task signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this repository uses a "Merge Forward" strategy