fix: recover Server.name from storage on alarm wake#331
Open
jcheese1 wants to merge 1 commit intocloudflare:mainfrom
Open
fix: recover Server.name from storage on alarm wake#331jcheese1 wants to merge 1 commit intocloudflare:mainfrom
jcheese1 wants to merge 1 commit intocloudflare:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Server.nameto DO storage insetName(), recover it at the top ofalarm()when#_nameis unsetthis.nameis read insideonAlarm()or schedule callbacks after a cold wake (alarm is the only entry point that never calledsetName())Agent.runWorkflow()readsthis.nameto inject__agentName— crashes when triggered bythis.schedule()Test plan
AlarmNameServertest DO with seed endpoint that writes name to storage without callingsetName(), simulating cold wakenameWasCold: true(proving storage recovery path was exercised, not a warm instance no-op)this.namereturns correct value insideonAlarm()