feat: add LogOutput::Custom variant for user-provided slog drains#206
Merged
Conversation
Add a Custom variant to LogOutput that accepts an Arc<dyn CustomDrain>. This allows users to provide their own slog drain (e.g., for Sentry integration) without needing wrapper macros or other workarounds. The custom drain: - Receives the same downstream wrapping as built-in drains (field dedup, field redaction, etc.) - Is not serializable (must be set in code, not YAML) - Ignores LogFormat (responsible for its own formatting) The Custom variant uses Arc<dyn ...> instead of Box<dyn ...> because: 1. LogOutput must be Clone because LoggingSettings is cloned in telemetry::init(). Box<dyn ...> is not Clone. 2. telemetry::init() receives &LoggingSettings. A Box cannot be moved out of a shared reference, but an Arc can be cheaply cloned from one. Changing init() to take ownership would be a breaking API change. Co–authored–by: Claude Opus 4.6
ksurent
force-pushed
the
ksurent/custom-slog-drain
branch
from
8218f9a to
69746bf
Compare
TheJokr
reviewed
May 18, 2026
TheJokr
approved these changes
May 18, 2026
Collaborator
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Custom variant to LogOutput that accepts an Arc. This allows users to provide their own slog drain (e.g., for Sentry integration) without needing wrapper macros or other workarounds.
The custom drain:
The Custom variant uses Arc<dyn ...> instead of Box<dyn ...> because:
LogOutput must be Clone because LoggingSettings is cloned in telemetry::init(). Box<dyn ...> is not Clone.
telemetry::init() receives &LoggingSettings. A Box cannot be moved out of a shared reference, but an Arc can be cheaply cloned from one. Changing init() to take ownership would be a breaking API change.
Co–authored–by: Claude Opus 4.6