Conversation
|
/bonk recommend improvements to this changelog |
There was a problem hiding this comment.
Review
The content looks good — the frontmatter, component import, and CVE descriptions are all correct. I noticed one category of issue that should be addressed: inconsistent indentation in the HTML table.
Inconsistent indentation in <tbody> section
Comparing against existing WAF changelog entries (e.g., 2025-11-17-waf-release.mdx, 2025-11-03-waf-release.mdx), the established convention uses consistent tab indentation throughout the entire table. The new file mixes tabs and spaces, and has misaligned elements within <tbody>.
Specifically:
<tbody>on line 29 uses spaces instead of a tab<tr>,<td>, and</tr>elements inside<tbody>use spaces with inconsistent levels- The first
</tr>(line 39) uses 2-space indent while the second</tr>(line 50) uses a tab+spaces mix
The indentation should match the convention used in the <thead> section of the same file and in all other WAF changelogs: tab-based indentation with consistent nesting depth.
Note: pedrosousa's suggestion on line 50 for the closing </tr> tag fixes the immediate build issue there, but the rest of the <tbody> still has mixed indentation that should ideally be cleaned up for consistency.
|
Review posted on PR #28316. Here's a summary of what I found: Content: The frontmatter, component import, CVE descriptions, and table data are all correct and follow the established WAF changelog pattern. Issue found: The |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@rag-cf Do we need to update the Scheduled changes page to remove the two entries? |
Add rules for Feb16 release