Skip to content

Lower TypeScript keynote bench threshold #5333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clockwork-labs-bot wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Lower TypeScript keynote bench threshold #5333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/ci/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ Usage: help [COMMAND]...

Runs the keynote benchmark as a CI performance regression gate.

Assumes release SpacetimeDB binaries and the TypeScript SDK are already built, runs the keynote SpacetimeDB benchmark for 60 seconds against the TypeScript and Rust modules, and fails if throughput is below 275K TPS for TypeScript or 300K TPS for Rust.
Assumes release SpacetimeDB binaries and the TypeScript SDK are already built, runs the keynote SpacetimeDB benchmark for 60 seconds against the TypeScript and Rust modules, and fails if throughput is below 260K TPS for TypeScript or 275K TPS for Rust.

**Usage:**
```bash
Expand Down
2 changes: 1 addition & 1 deletion tools/ci/src/keynote_bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const BENCHMARK_MODULES: &[BenchmarkModule] = &[
BenchmarkModule {
label: "TypeScript",
module_dir: "templates/keynote-2/spacetimedb",
min_tps: 275_000.0,
min_tps: 260_000.0,
},
BenchmarkModule {
label: "Rust",
Expand Down
2 changes: 1 addition & 1 deletion tools/ci/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ enum CiCmd {
///
/// Assumes release SpacetimeDB binaries and the TypeScript SDK are already built, runs the
/// keynote SpacetimeDB benchmark for 60 seconds against the TypeScript and Rust modules, and
/// fails if throughput is below 275K TPS for TypeScript or 300K TPS for Rust.
/// fails if throughput is below 260K TPS for TypeScript or 275K TPS for Rust.
KeynoteBench,
/// Tests the update flow
///
Expand Down
Loading