Add small module-test* as a compile check for http handlers#5330
Open
JasonAtClockwork wants to merge 1 commit into
Open
Add small module-test* as a compile check for http handlers#5330JasonAtClockwork wants to merge 1 commit into
JasonAtClockwork wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
HTTP handlers already have smoketest coverage, but in order to add to
module-tests all languages had to have parity asmodule-testhas a check to ensure schemas match.The existing integration tests using
module-testload SpacetimeDB in memory, expanding these tests would require significant and potentially ugly work to handle hosting for HTTP handlers. Instead, this PR adds compile-only for eachmodule-testwith a matching handler + route.API and ABI breaking changes
N/A
Expected complexity level and risk
1 - tiny addition to
module-testfor all languagesTesting
cargo test -p spacetimedb-schema module_testcargo test -p spacetimedb-testing