Move RelationalDB to spacetimedb-engine crate.#5113
Open
Shubham8287 wants to merge 17 commits into
Open
Conversation
Contributor
|
Why is "Expected complexity level and risk" unspecified? Could you please update. I assume you're saying it's low risk because it's just mechanical? |
Contributor
Author
No, I would have come to back it, when asked someone to review it. It is draft rn. (I should have marked). |
Shubham8287
force-pushed
the
shub/engine
branch
4 times, most recently
from
312d9d7 to
59e77cf
Compare
Shubham8287
commented
Jun 10, 2026
joshua-spacetime
approved these changes
Jun 12, 2026
pull Bot
pushed a commit
to Abaso007/SpacetimeDB
that referenced
this pull request
Jun 15, 2026
…lockworklabs#5255) # Description of Changes Runtime specific changes from clockworklabs#5113. - `spacetimedb-runtime` enforces exactly one feature at compile time: `tokio` or `simulation`. It rejects both-enabled and neither-enabled builds explicitly. - This also keeps `tokio::sync` re-exported from runtime, look at code comment for reasoning. # API and ABI breaking changes NA # Expected complexity level and risk 1
cloutiertyler
approved these changes
Jun 15, 2026
…db-engine, add ParamResolver import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Moves
RelationalDBand related database code into a newspacetimedb-enginecrate.The main motivation is to tighten dependency control around the engine layer and isolate
RelationalDBbehind a crate boundary.
tokiofromspacetimedb-engine.tokioonly as a dev-dependency for test-only code inspacetimedb-engine.production.
spacetimedb-enginecontinues to compile in simulation modeAPI and ABI breaking changes
NA
Expected complexity level and risk
1.5.
Testing
Existing tests should be enough.