Skip to content

fix(ci): skip integration tests for fork PRs#8211

Merged
jacekradko merged 2 commits intomainfrom
jacek/skip-integration-tests-fork-prs
Mar 31, 2026
Merged

fix(ci): skip integration tests for fork PRs#8211
jacekradko merged 2 commits intomainfrom
jacek/skip-integration-tests-fork-prs

Conversation

@jacekradko
Copy link
Copy Markdown
Member

@jacekradko jacekradko commented Mar 31, 2026

Summary

  • Fork PRs don't have access to repo secrets (INTEGRATION_CERTS, INTEGRATION_ROOT_CA), causing JSON.parse('') crashes in the integration-tests job
  • Adds a condition to skip integration tests for fork PRs by checking head.repo.full_name == github.repository, matching the pattern already used in the check-permissions job

Test plan

  • Verify same-repo PRs still run integration tests
  • Verify merge_group events still run integration tests
  • Verify fork PRs skip the integration-tests job entirely (no crash)

Fork PRs do not have access to repository secrets. The integration-tests
job calls JSON.parse(process.env.INTEGRATION_CERTS) which crashes with
an empty string, causing 24 out of 30 jobs to fail immediately.

Skip the entire integration-tests job for fork PRs by checking that the
head repo matches the base repo, using the same pattern already used in
the check-permissions job.
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Mar 31, 2026 11:29am

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

⚠️ No Changeset found

Latest commit: ad2cce5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 31, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8211

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8211

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8211

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8211

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8211

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8211

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8211

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8211

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8211

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8211

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8211

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8211

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8211

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8211

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8211

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8211

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8211

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8211

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8211

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8211

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8211

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8211

commit: ad2cce5

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

📝 Walkthrough

Walkthrough

The .github/workflows/ci.yml file was updated to modify the integration-tests job's conditional logic. The if: condition was changed from a simple non-draft PR or non-PR event check to a more restrictive expression. The new condition additionally gates PR execution to scenarios where the PR's head repository matches the current repository, while preserving existing non-PR behavior. The condition is now structured as a multiline folded YAML boolean expression with two conjunctive clauses.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a condition to skip integration tests for fork PRs by checking if the head repository matches the target repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jacekradko jacekradko merged commit d03c8ae into main Mar 31, 2026
42 checks passed
@jacekradko jacekradko deleted the jacek/skip-integration-tests-fork-prs branch March 31, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants