-
Notifications
You must be signed in to change notification settings - Fork 435
fix(astro): Automatically use CSR Show component for prerendered pages #7710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dc35671
chore: add changeset
wobsoriano e8a7e0c
fix(astro): Automatically use CSR control components for prerendered …
wobsoriano 9afbe03
chore: adapt prerendered tests to use Show component
wobsoriano fc04fe3
chore: add changeset
wobsoriano 1cd67a7
fix: guard Astro.locals
wobsoriano 53495be
Merge branch 'main' into rob/fix-astro-prerendered-core-3
wobsoriano 59a0875
Merge branch 'main' into rob/fix-astro-prerendered-core-3
wobsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@clerk/astro": patch | ||
| --- | ||
|
|
||
| Fixed an error when using Control components in prerendered pages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
integration/templates/astro-node/src/pages/prerendered.astro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| import { Show } from '@clerk/astro/components'; | ||
| import Layout from '../layouts/Layout.astro'; | ||
|
|
||
| // This page is prerendered at build time despite output: 'server' mode | ||
| export const prerender = true; | ||
| --- | ||
|
|
||
| <Layout title='Prerendered Page Test'> | ||
| <h1>Prerendered Page with Clerk Components</h1> | ||
|
|
||
| <p>This page is statically generated at build time (prerender = true) in server output mode.</p> | ||
|
|
||
| <Show when='signed-in'> | ||
| <div id="signed-in-content"> | ||
| <p>✅ You are signed in! (This content should be hidden initially and shown after client-side auth check)</p> | ||
| </div> | ||
| </Show> | ||
|
|
||
| <Show when='signed-out'> | ||
| <div id="signed-out-content"> | ||
| <p>🔒 You are signed out. (This content should be visible initially for signed-out users)</p> | ||
| </div> | ||
| </Show> | ||
| </Layout> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.