feat(cli): add TRACEROUTE Hops column to checks stats [SIM-278]#1385
Open
danielpaulus wants to merge 1 commit into
Open
feat(cli): add TRACEROUTE Hops column to checks stats [SIM-278]#1385danielpaulus wants to merge 1 commit into
danielpaulus wants to merge 1 commit into
Conversation
Adds a bespoke `Hops` column for TRACEROUTE checks in `checkly checks stats`, mirroring the ICMP Latency/Pkt Loss bespoke-column pattern. TRACEROUTE keeps its final-hop-latency Resp columns (stays in TIMING_TYPES) and additionally shows hop count from the new hopCount_avg field. Follow-up to #1362 (stacked on feat/cli-pertype-result-rendering). hopCount_avg is populated by the SIM-278 backend change; until it deploys the column renders a dash. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a bespoke
Hopscolumn for TRACEROUTE checks incheckly checks stats, mirroring the existing ICMPLatency/Pkt Lossbespoke-column pattern.CLI half of SIM-278 — the follow-up @sorccu deferred from #1362.
How
src/formatters/batch-stats.ts: TRACEROUTE stays inTIMING_TYPES(so it keeps its final-hop-latencyResp (avg)/Resp (p95)columns — no regression) and additionally gets aHopscolumn, gated onhasTracerouteexactly like the ICMP branch is gated onhasIcmp. Added in both the markdown and terminal branches ofbuildColumns().src/rest/batch-analytics.ts: newhopCount_avgfield onBatchAnalyticsResult.src/commands/checks/stats.ts:hopCount_avgadded to the JSON output.src/formatters/__tests__/batch-stats.spec.tscovering the Hops column (present for TRACEROUTE, keeps final-hop latency, dash for non-traceroute rows in a mixed batch, column omitted when no traceroute present, dash when hopCount is null).Dependencies / rollout
feat/cli-pertype-result-rendering), which is what puts TRACEROUTE inTIMING_TYPES. Base this PR on that branch; it should merge after feat(cli): gRPC/SSL/Traceroute typed result rendering + IaC constructs #1362.hopCount_avgis populated by a backend change (SIM-278 backend PR, exposinghopCount_avgfrommetadata_TRACEROUTE_totalHopsin the batch-analytics endpoint). Until that deploys, theHopscolumn renders—— intended, non-breaking.Tests / lint
batch-stats.spec.ts(5) + existinganalytics.spec.ts(49) pass. eslint + tsc clean.Related gap (NOT fixed here — for a separate ticket)
CLI per-check analytics (
src/rest/analytics.ts) has nocheckTypeToPath/defaultMetricsentry for TRACEROUTE (nor GRPC/SSL), socheckly checks get <tracerouteId>analytics throws "Unsupported check type". Out of scope for this batch-stats change; flagging for follow-up.🤖 Generated with Claude Code