Skip to content

fix: dclogin links for IP addresses need square brackets #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
missytake wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: dclogin links for IP addresses need square brackets #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5edc60
fix: dclogin links for IP addresses need square brackets
missytake Apr 22, 2026
0355eb9
fix: relay username length is 9 by default
missytake Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cmping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ def generate_credentials():
"""Generate random username and password for IP-based login.

Returns:
tuple: (username, password) where username is 12 chars and password is 20 chars
tuple: (username, password) where username is 9 chars and password is 20 chars
"""
chars = string.ascii_lowercase + string.digits
username = "".join(random.choices(chars, k=12))
username = "".join(random.choices(chars, k=9))
password = "".join(random.choices(chars, k=20))
return username, password

Expand All @@ -87,7 +87,7 @@ def create_qr_url(domain_or_ip):
domain_or_ip: Either a domain name or an IP address

Returns:
str: Either dcaccount:domain or dclogin:username@ip/?p=password&v=1&ip=993&sp=465&ic=3&ss=default
str: Either dcaccount:domain or dclogin:username@[ip]/?p=password&v=1&ih=ip&sh=ip&ip=993&sp=465&ic=3&ss=default
"""
if is_ip_address(domain_or_ip):
# Generate credentials for IP address
Expand All @@ -99,8 +99,8 @@ def create_qr_url(domain_or_ip):

# Format: dclogin:username@host/?query
qr_url = (
f"dclogin:{username}@{domain_or_ip}/?"
f"p={encoded_password}&v=1&ip=993&sp=465&ic=3&ss=default"
f"dclogin:{username}@[{domain_or_ip}]/?"
f"p={encoded_password}&v=1&ih={domain_or_ip}&sh={domain_or_ip}&ip=993&sp=465&ic=3&ss=default"
)
return qr_url
else:
Expand Down