-
-
Notifications
You must be signed in to change notification settings - Fork 0
Tweak publishing setup #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
cbcc756
1c7a00b
e8bd807
f734f67
b9460a8
e46e51c
abf713a
bca6aa2
b2fe376
26ec818
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| name: Setup CI | ||
| description: Setup CI | ||
|
|
||
| inputs: | ||
| node-version: | ||
| description: Node.js version | ||
| required: false | ||
| default: 24 | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The idea with defaulting to 22 was that our CI should test against the oldest supported version. I assume you have decided it's an overkill here - that's fine with me, I'm just doublechecking
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I figured it's simpler to only test node 24 |
||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Set up pnpm | ||
| uses: pnpm/action-setup@91ab88e2619ed1f46221f0ba42d1492c02baf788 # v6.0.6 | ||
|
|
||
| - name: Set up Node.js ${{ inputs.node-version }} | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version: ${{ inputs.node-version }} | ||
| cache: pnpm | ||
|
|
||
| - name: Install dependencies | ||
| shell: bash | ||
| run: pnpm install | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity - why do we need description too? I can't find the docs for this description field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a weird one I think. In VS Code, I have the github actions extension (official) installed, which gives nice intellisense and stuff. For some reason it marked the whole file red without the description, so I added it to please it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the docs: https://docs.github.com/en/actions/reference/workflows-and-actions/metadata-syntax#description